Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import pipe from dplyr and not magrittr #72

Open
MarcinKosinski opened this issue Jan 3, 2018 · 0 comments
Open

import pipe from dplyr and not magrittr #72

MarcinKosinski opened this issue Jan 3, 2018 · 0 comments

Comments

@MarcinKosinski
Copy link
Contributor

This 1-liner https://github.com/MI2DataLab/factorMerger/blob/master/R/factorMergerClasses.R#L6 drives the final user to install an extra package. There is no point to import pipe operator from the extra package when you have one in the dplyr. Less dependencies, the better. Just remove this line, after you fully import dplyr.

magrittr is a sophisticated tool to be used when one is familiar with extract , extract2, multiple_by , add equals , not or many more functions. If those are not in the need, just don't anticipate anyone to install extra software. Less dependencies, less problems in the future with the reproducible research.

CC @durszlaczek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant