Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When the gltFast project hits its Git LFS limit, the MRTK3 sample project fails to work #630

Open
ms-RistoRK opened this issue Feb 2, 2024 · 3 comments · May be fixed by #631
Open
Assignees
Labels
Status: External An issue caused by factors external to the MRTK project. Type: Bug A problem with an existing feature that can be fixed with the next patched release.

Comments

@ms-RistoRK
Copy link
Contributor

Describe the bug

A fresh clone of MRTK3 main branch repo fails to load in Unity Editor with Unity Package Manager Error shown next:

image

To reproduce

  1. Clone MRTK3 main branch locally
  2. Use Unity Hub to add project located in <REPO_ROOT>\UnityProjects\MRTKDevTemplate
  3. See error

image

Expected behavior

After Step 2, Unity Editor should open, import packages, without displaying any Unity Package Manager Error.

Screenshots

image

Your setup (please complete the following information)

  • Unity Version 2021.3.21f1
  • MRTK Version: 3 or Commit [e.g. v3.0] [e.g. 3aa92c5]

Target platform (please complete the following information)

  • Windows 11 Desktop

Additional context

It seems that a package from https://github.com/atteneder/glTFast is registered in the package manager.

@ms-RistoRK ms-RistoRK added Type: Bug A problem with an existing feature that can be fixed with the next patched release. Needs: Triage Needs to be triaged. labels Feb 2, 2024
@ms-RistoRK ms-RistoRK self-assigned this Feb 2, 2024
@AMollis AMollis changed the title [BUG] [BUG] When the gltFast project hits its Git LFS limit, the MRTK3 sample project fails to work Feb 5, 2024
@AMollis
Copy link
Contributor

AMollis commented Feb 5, 2024

This in some way is an external issue. We can look at updating the sample to Unity gltf plugin instead, which wouldn't have the same issues.

@AMollis AMollis added Status: External An issue caused by factors external to the MRTK project. and removed Needs: Triage Needs to be triaged. labels Feb 5, 2024
@ms-RistoRK
Copy link
Contributor Author

Won't fix because:

  • We lack the resources to exhaustively test the proposed fix in all devices where MRTK3 is deployed and Qualcomm has suggested to test the proposed fix on their devices.
  • The issue is known and accepted.
    For historical reference: The PR that was proposing a solution is this one: Update to support UPM packages for glTF #631

@keveleigh keveleigh reopened this Feb 7, 2024
@keveleigh
Copy link
Contributor

Re-opening to continue tracking. Assigning to myself.

@keveleigh keveleigh assigned keveleigh and unassigned ms-RistoRK Feb 7, 2024
@keveleigh keveleigh linked a pull request Jan 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: External An issue caused by factors external to the MRTK project. Type: Bug A problem with an existing feature that can be fixed with the next patched release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants