Property 'redraw' does not exist on type 'Event'

[pygy]

Hey there :-)

It may be nice to have maybe a Mithril.Event with an added redraw: boolean field.

Or did I miss it?

[spacejack]

Yeah that would be handy as a convenience type to include. I think you'd still need to annotate it yourself:

m('button', {onclick: (e: m.Event) => {e.redraw = false}}, "Don't redraw!");

Unless we can do something clever with the Attrs type...

[spacejack]

Thinking about this a bit more, might be more useful to extend all possible events. It could be made more user friendly by adding these and these (and other...?) properties to Attrs.

Eg:

export interface VEvent {
    redraw: boolean
}

export interface Attrs {
    // ...
    onblur?: (this: HTMLElement, ev: FocusEvent & VEvent) => any;
    onclick?: (this: HTMLElement, ev: MouseEvent & VEvent) => any;
    // etc...

[spacejack]

Here's a gist of everything I can think of at the moment:

https://gist.github.com/spacejack/73ae839c4a80a2dfaa88294caec3605f

[spacejack]

I've added a new branch event-types.

@isiahmeadows, @andraaspar what do you think: https://github.com/spacejack/mithril.d.ts/compare/event-types

[pygy]

LGTM :-)

[dead-claudia]

LGTM, although I wish we could concatentate string keys with mapped types, so we wouldn't need to manage the big list ourselves... (TypeScript doesn't allow it though, sadly.)

[spacejack]

Something I should point out about this change, if you're using external event handler functions, you'd need to annotate them like this: https://github.com/spacejack/mithril.d.ts/blob/event-types/test/test-api.ts#L649

[oldrich-s]

@isiahmeadows Is it not solved by my proposal?: #24