Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FragmentPagerAdapter subclass must implement getPageTitle #2

Open
alunsford3 opened this issue Jul 22, 2014 · 0 comments
Open

FragmentPagerAdapter subclass must implement getPageTitle #2

alunsford3 opened this issue Jul 22, 2014 · 0 comments

Comments

@alunsford3
Copy link

In TabBarView you are calling pager.getAdapter().getPageTitle(i).toString() which will throw an NPE if it is unimplemented. Since getPageTitle is not abstract, the CharSequence returned should be checked.

https://github.com/Mirkoddd/TabBarView/blob/master/TabBarViewLibrary/src/com/mirko/tbv/TabBarView.java#L174
plackemacher added a commit to plackemacher/TabBarView that referenced this issue Jul 23, 2014
@plackemacher
Correct issue that occurs if the adapter passed to TabBarView doesn't…
a373984 
… override getPageTitle(), resulting in a NullPointerException

See Mirkoddd#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alunsford3