[Dev] Remove version linter flakiness #14998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe reference file. Now it downloads 10 last commits on base and release branch and tries to to match type shape for any of it. Thanks to that we drastically lower possibility of failure when attempting to get type shape file based on commit sha
|
!ci-build-me |
mrmr1993
requested changes
Jan 29, 2024
There was a problem hiding this comment.
See comment. I'm pretty sure that fixing that bug will also induce the flakiness again though; it would probably be more disciplined to generate and upload the shapes for the parent commit as required instead, in some job that the check depends upon, and short circuiting when the corresponding shape file exists.
scripts/version-linter.py
Outdated
| print ('Retrieving', branch, 'head commit...') | ||
| result=subprocess.run(['git','log','-n','1','--format="%h"','--abbrev=7','--no-merges',f'{branch}'], | ||
| result=subprocess.run(['git','log','-n',str(n),'--format="%h"','--abbrev=7','--no-merges',f'{branch}'], |
There was a problem hiding this comment.
I think this is the opposite of what we want. We really want the last n 'first-parent' commits, each of which represents a merge to the target branch from a PR. Consider instead
git log -n N --format="%h" --abbrev=7 --first-parent BRANCH
…pe reference file. Now it downloads 10 last commits on base and release branch and tries to to match type shape for any of it. Thanks to that we drastically lower possibility of failure when attempting to get type shape file based on commit sha
…://github.com/MinaProtocol/mina into dkijania/fix_missing_ref_files_for_ver_linter
dkijania
force-pushed
the
dkijania/fix_missing_ref_files_for_ver_linter
branch
from
931ded8 to
43a532a
Compare
|
!ci-build-me |
|
!ci-build-me |
…release branch when BUILDKITE_PULL_REQUEST_BASE_BRANCH is not defined
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
…ania/fix_missing_ref_files_for_ver_linter
|
!ci-build-me |
…nafly_master' into dkijania/generate_version_lint_inafly_master
…ania/fix_missing_ref_files_for_ver_linter
|
!ci-build-me |
|
!ci-build-me |
This reverts commit 484dd949cf7b6012ffc7a7712ca286e0dfe0e50f.
…ania/fix_missing_ref_files_for_ver_linter
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
stale. closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix version linter job flakiness by retrieving more than 1 commit from base and release branch and trying to find reference type shape best on shas retrieved in such way. For pr branch still we are getting only one (last) commit.
Closes: #14812