Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show measures on tasks tab on algorithm page #385

Closed
5 of 7 tasks
anneschuth opened this issue Nov 21, 2024 · 1 comment · Fixed by #478
Closed
5 of 7 tasks

Show measures on tasks tab on algorithm page #385

anneschuth opened this issue Nov 21, 2024 · 1 comment · Fixed by #478
Assignees

Comments

@anneschuth
Copy link
Member

anneschuth commented Nov 21, 2024

Description

  • We want to use the tasks/card-view to have an overview over all measures and their statuses.

  • Columns can be wider than the tabs (we'll need a max-width for a column)

  • We will still show the measures on the Requirements tab, but additionally we will also show them as cards on the tasks section.

  • We will use the status info of the task, to know in which column we should display the measure card.

  • When someone click on a measure card, the modal to edit the card will be opened.

  • By default we will order the tasks based on the order present in Algoritmekader.
    The measures on Algoritmekader are ordered by lifecycle and id.
    Primary Order (id based on lifecycle abbreviation):

    1. org (organisatieverantwoordelijkheden)
    2. pba (probleemanalyse)
    3. owp (ontwerp)
    4. dat (dataverkenning-en-datapreparatie)
    5. owk (ontwikkelen)
    6. ver (verificatie-en-validatie)
    7. imp (implementatie)
    8. mon (monitoring-en-beheer)

    Secondary Order (numeric suffix): e.g. org-01, ver-03,
    We can use the AK filenames to determine the above order.

  • People working on the algorithm tasks can change the order of the cards, and we should respect this manually change of order.

  • Business rules should be used for drag and drop permissions. An error message should be displayed if an action is not according to the business rules.

Business rules for each function:

  Verantwoordelijke/Accountable Uitvoerende/Responsible Controlerend/Reviewer Any other teammember
Move task to ‘To do’ ‘Doing’ ‘Review X X X
Move task to ‘Overslaan’ X    
Move task to ‘Done’ X  
Assign Verantwoordelijke/Accountable X X X X
Assign Uitvoerende/Responsible X X X X
Assign Adviserend/Consulted X  X X X
  • Columns are only grayed out in drag-mode.
  • Tasks in columns that a user can not drag to can still be opened by the user.

UI:

Image

Technical Implementation

  • drag and drop must be supported with function business rules.
  • when an algorithm is created in AMT, all measure-tasks are created in the tasks table with the order of cards initialized as explained above (users are then free to change the order of cards).
  • tasks only store the urn, all metadata comes from the (cached) task registry
  • depends on Implement an urn resolver in the task registry #403
  • other columns in the tasks table are dropped.
  • we keep the tasks table and we only store a UUID. All task related data is retrieved from and stored in the system card.
  • Enforce business rules when dragging a task on the tasks board #477
    • ENG: "Action not allowed. Only [right_function] can move measures to [target_status] status."
    • NL: “Actie niet toegestaan. Alleen [juiste_functie] kan maatregelen verplaatsen naar de status [doel_status].”
@anneschuth anneschuth converted this from a draft issue Nov 21, 2024
@robbertbos robbertbos changed the title Show measures to tasks tab on algorithm page Show measures on tasks tab on algorithm page Nov 21, 2024
@uittenbroekrobbert uittenbroekrobbert moved this from ♻ To Do to 👷 In Progress in 👾 AI Validation Team Planning Jan 16, 2025
@uittenbroekrobbert uittenbroekrobbert self-assigned this Jan 16, 2025
@uittenbroekrobbert uittenbroekrobbert linked a pull request Jan 22, 2025 that will close this issue
5 tasks
@uittenbroekrobbert
Copy link
Contributor

The enforce business rules have not been implemented; this should become a separate ticket. The columns title and description for a task are currently not dropped; I expect we might need them later on.

@uittenbroekrobbert uittenbroekrobbert moved this from 👷 In Progress to 👀 In Review in 👾 AI Validation Team Planning Jan 22, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 👾 AI Validation Team Planning Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants