Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the inline "style" in AMT HTML elements #325

Open
robbertbos opened this issue Oct 28, 2024 · 2 comments
Open

Remove all the inline "style" in AMT HTML elements #325

robbertbos opened this issue Oct 28, 2024 · 2 comments

Comments

@robbertbos
Copy link
Member

robbertbos commented Oct 28, 2024

Description

It is a bad practice to add the "style" into the HTML elements directly, but this has been introduced by the crunch week before the demo. Integrate them in the .css files (which potentially should be more logically grouped into different .css files) and where necessary make our own NL-Design System components as they are too different from RVO (hence why we introduced the overwrite with the style elements)

Implementation notes

  • Make several CSS files
  • Create own css classes
@robbertbos robbertbos converted this from a draft issue Oct 28, 2024
Copy link
Contributor

This issue did not have any activity in the last 90 days and will be removed after 30 days

@github-actions github-actions bot added the Stale label Feb 11, 2025
@robbertbos
Copy link
Member Author

@github-actions github-actions bot removed the Stale label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ♻ To Do
Development

No branches or pull requests

1 participant