Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the docker build issues for AMT #179

Open
anneschuth opened this issue Sep 4, 2024 · 2 comments
Open

Fix the docker build issues for AMT #179

anneschuth opened this issue Sep 4, 2024 · 2 comments

Comments

@anneschuth
Copy link
Member

anneschuth commented Sep 4, 2024

Situation

For building AMT, we use docker. As 'project base' we use a vendor image with Python pre-installed. This image is modified for the different purposes during build, like building the Python project, running tests and creating the production image.

The CI/CD creates the image each time 'from scratch', including an apt-get update and installing poetry, NVM and NodeJS.

This proces worked flawlessly, until we introduced NVM/NodeJS. For unknown reasons, downloading the required NodeJS package from the NodeJS website fails sometimes resulting in failing CI/CD.

Solution

Split up the build for Python and NodeJS and use a different docker image for each step. This is however a bit complex, as our NPM webpack build generates javascript and stylesheets, but also creates jinja templates (from webpack templates). This means after this build, the results have to be copied to the next steps; but, that should be possible. There seems to be a NodeJS image: https://hub.docker.com/layers/library/node/20.16.0-bullseye-slim/images/sha256-69f4fc9de15e0a6315be58fa94d46f7cdc37fdf685d431727d1f49e4133ae6a0

Copy link
Contributor

github-actions bot commented Dec 5, 2024

This issue did not have any activity in the last 90 days and will be removed after 30 days

@github-actions github-actions bot added the Stale label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2025

This issue is closed due to inactivity

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
@github-project-automation github-project-automation bot moved this from ♻ To Do to ✅ Done in 👾 AI Validation Team Planning Jan 5, 2025
@robbertbos robbertbos moved this from ✅ Done to ♻ To Do in 👾 AI Validation Team Planning Jan 6, 2025
@robbertbos robbertbos removed the Stale label Jan 6, 2025
@robbertbos robbertbos reopened this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ♻ To Do
Development

No branches or pull requests

3 participants
@anneschuth @robbertbos and others