Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does TestItems need to be a dependency? #45

Closed
avik-pal opened this issue Jul 4, 2024 · 1 comment
Closed

Does TestItems need to be a dependency? #45

avik-pal opened this issue Jul 4, 2024 · 1 comment

Comments

@avik-pal
Copy link
Contributor

avik-pal commented Jul 4, 2024

It seems like it isn't being used in src https://github.com/search?q=repo%3AMilesCranmer%2FDispatchDoctor.jl+testitem+path%3A%2F%5Esrc%5C%2F%2F&type=code.

It probably doesn't matter too much since it is extremely lightweight.
@MilesCranmer
Copy link
Owner

Good point, I should delete it. Originally there were some @testitem throughout the codebase (which TestItemRunner will run automatically – makes TDD-like work significantly faster to have tests) but I moved to test/ because it is easily-confused with source code (julia-vscode/TestItemRunner.jl#70)

@avik-pal avik-pal closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MilesCranmer @avik-pal