Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with Object:calculateDisplacement function #74

Closed
MikeHeiber opened this issue Aug 9, 2020 · 0 comments · Fixed by #75
Closed

Problem with Object:calculateDisplacement function #74

MikeHeiber opened this issue Aug 9, 2020 · 0 comments · Fixed by #75
Assignees
@MikeHeiber
Labels
bug Mistake in the code that causes a testable error.

Comments

@MikeHeiber
Copy link
Owner

Originating from this issue in Excimontec MikeHeiber/Excimontec#111, it appears that the calculateDisplacement function is not producing the desired behavior of calculating the displacement along a particular direction. It is currently calculating the absolute displacement which does not distinguish between positive and negative displacements, even though this is how it is being used.
@MikeHeiber MikeHeiber added the bug Mistake in the code that causes a testable error. label Aug 9, 2020
@MikeHeiber MikeHeiber self-assigned this Aug 9, 2020
@MikeHeiber MikeHeiber mentioned this issue Aug 9, 2020
Merged
MikeHeiber pushed a commit that referenced this issue Aug 9, 2020
Calculate Displacement Update (#75)
27e02c6 
Resolves #74 
- Updated Changelog to note all changes
- Regenerated docs
- Updated copyright in Object class files
- Updated Object::calculateDisplacement function to calculate the net displacement when specifying and direction instead of the absolute displacement and updated the documentation accordingly
- Updated CalculateDisplacement units tests to check for negative displacement when specifying the displacement direction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeHeiber MikeHeiber

Labels
bug Mistake in the code that causes a testable error.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calculate Displacement Update MikeHeiber/KMC_Lattice
1 participant
@MikeHeiber