Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use sub-module #2

Closed
dcworldwide opened this issue May 19, 2015 · 6 comments
Closed

Please use sub-module #2

dcworldwide opened this issue May 19, 2015 · 6 comments

Comments

@dcworldwide
Copy link

Hi @dandv, could you use a sub-module so that the project stays in sync with upstream? I can sub a PR if you point me in the right direction. I've never set one up so not sure how to go about it.

@dandv
Copy link

dandv commented May 20, 2015

The project can be synced with the upstream right now:

git remote add upstream [email protected]:nnnick/Chart.js.git
git fetch upstream
git merge upstream/master
git push origin master

For the future, we're moving towards submodules indeed (see my Webix skin wrappers, for example). There's a new "sister repo" approach, which @splendido might be able to help with.

@splendido
Copy link
Member

yes, @dandv is right...
We're playing with jsPDF and snap.svg to see whether we can converge on a standard and simple approach.
Please see jspdf-core-wrapper, jspdf-AutoTable-wrapper, and snapsvg-wrapper. And a bit of discussion here and here

If you like to join the party, please let me know and I'll create a brand new repo for the chart.js wrapper.

@dcworldwide
Copy link
Author

Thanks all. I'm glad that you are tackling this issue I think it is a major meteor component in need for improvement

@macrozone
Copy link

this package hasn't been updated for some time. Could you please publish a new release to atmosphere?

@cshanejennings
Copy link

Agreed, running into an issue with the older version. Any plans to update?

@dandv
Copy link

dandv commented Aug 17, 2016

@dandv dandv closed this as completed Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants