From 454fb3847d4a58dc49e94ea3bc3a59d1820e0597 Mon Sep 17 00:00:00 2001 From: legobeat <109787230+legobeat@users.noreply.github.com> Date: Mon, 1 May 2023 12:52:22 +0000 Subject: [PATCH 1/2] Revert "ci: temporarily downgrade ubuntu to 20.04" (#5199) This reverts commit 55421938306b9302ccfa8f3751536f5f24ffcbce. --- .github/workflows/bump-version-name.yml | 2 +- .github/workflows/cla.yml | 2 +- .github/workflows/create-release-pr.yml | 2 +- .github/workflows/crowdin_action.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/bump-version-name.yml b/.github/workflows/bump-version-name.yml index 9e1de2231b3..96b899d71b4 100644 --- a/.github/workflows/bump-version-name.yml +++ b/.github/workflows/bump-version-name.yml @@ -7,7 +7,7 @@ on: types: [opened] jobs: bump-version-name: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest if: "contains(github.head_ref, 'release/')" permissions: contents: write diff --git a/.github/workflows/cla.yml b/.github/workflows/cla.yml index 93758bae919..0f7977000c6 100644 --- a/.github/workflows/cla.yml +++ b/.github/workflows/cla.yml @@ -8,7 +8,7 @@ on: jobs: CLABot: if: github.event_name == 'pull_request_target' || contains(github.event.comment.html_url, '/pull/') - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest permissions: pull-requests: write contents: write diff --git a/.github/workflows/create-release-pr.yml b/.github/workflows/create-release-pr.yml index bb7c5767b5b..28b9070eccc 100644 --- a/.github/workflows/create-release-pr.yml +++ b/.github/workflows/create-release-pr.yml @@ -15,7 +15,7 @@ on: jobs: create-release-pr: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest permissions: contents: write pull-requests: write diff --git a/.github/workflows/crowdin_action.yml b/.github/workflows/crowdin_action.yml index 24cf9152bd6..119b13af130 100644 --- a/.github/workflows/crowdin_action.yml +++ b/.github/workflows/crowdin_action.yml @@ -13,7 +13,7 @@ on: jobs: synchronize-with-crowdin: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest steps: From effdbdbe8cacb25d5f7a46a40c49b93424ce1744 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Mon, 1 May 2023 11:27:55 -0230 Subject: [PATCH 2/2] Fix duplicate test name lint warning (#6304) The lint warning about a test title being repeated has been fixed. The two tests were very similar; the titles have been updated to explain how they are different. --------- Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com> --- app/util/number/index.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/util/number/index.test.ts b/app/util/number/index.test.ts index cae5f5bc2c6..361e1569fc0 100644 --- a/app/util/number/index.test.ts +++ b/app/util/number/index.test.ts @@ -781,10 +781,10 @@ describe('Number utils :: isZeroValue', () => { it('returns true for 0', () => { expect(isZeroValue(0)).toBe(true); }); - it('returns true for 0x0', () => { + it('returns true for hexadecimal string 0x0', () => { expect(isZeroValue('0x0')).toBe(true); }); - it('returns true for 0x0', () => { + it('returns true for hexadecimal integer literal 0x0', () => { expect(isZeroValue(0x0)).toBe(true); }); it('returns true for BN zero value', () => {