Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkController.lookupNetwork throws if messenger is cleared midway through #5115

Open
mcmire opened this issue Jan 8, 2025 · 0 comments · May be fixed by #5116
Open

NetworkController.lookupNetwork throws if messenger is cleared midway through #5115

mcmire opened this issue Jan 8, 2025 · 0 comments · May be fixed by #5116
Assignees
@mcmire
Labels
bug Something isn't working team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Jan 8, 2025

Within a client, if all of the subscriptions on the global messenger are cleared while lookupNetwork on the NetworkController is being called, it can cause the messenger to throw an error when lookupNetwork attempts to unsubscribe from the NetworkController:networkDidChange event. This happens in Mobile when destroying the engine. We should account for this.

Also see: MetaMask/metamask-mobile#12765
@mcmire mcmire added bug Something isn't working team-wallet-framework labels Jan 8, 2025
@mcmire mcmire self-assigned this Jan 8, 2025
@mcmire mcmire linked a pull request Jan 8, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcmire mcmire

Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NetworkController to handle clearing of messenger MetaMask/core
1 participant
@mcmire