Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle diagnostics that fail #327

Closed
jfrost-mo opened this issue Dec 11, 2023 · 1 comment · Fixed by #1039
Closed

Handle diagnostics that fail #327

jfrost-mo opened this issue Dec 11, 2023 · 1 comment · Fixed by #1039
Assignees
@jfrost-mo
Labels
enhancement New feature or request
Milestone
Major usability b...

Comments

@jfrost-mo
Copy link
Member

jfrost-mo commented Dec 11, 2023 •
edited
Loading

The entire workflow shouldn't crash if you are just missing a variable used by a single diagnostic. It should exit cleanly, and report the status on the CSET front page.
@jfrost-mo jfrost-mo added the enhancement New feature or request label Dec 11, 2023
@jfrost-mo jfrost-mo mentioned this issue Dec 21, 2023
Merged
6 tasks
@jfrost-mo jfrost-mo added this to the Major usability blockers milestone Oct 25, 2024
@jfrost-mo
Copy link
Member Author

I have mixed feelings on this one, as having the workflow hold if a task fails is very useful for debugging. It may be something we want to make dependent of whether debugging logging is enabled.

@jfrost-mo jfrost-mo self-assigned this Jan 16, 2025
jfrost-mo added a commit that referenced this issue Jan 16, 2025
@jfrost-mo
Require tasks to succeed in DEBUG mode
baa462b 
Fixes #327
@jfrost-mo jfrost-mo mentioned this issue Jan 16, 2025
Merged
7 tasks
jfrost-mo added a commit that referenced this issue Jan 16, 2025
@jfrost-mo
Require tasks to succeed in DEBUG mode
54a5945 
Fixes #327
jfrost-mo added a commit that referenced this issue Jan 16, 2025
@jfrost-mo
Require tasks to succeed in DEBUG mode
912a7a4 
Fixes #327
jfrost-mo added a commit that referenced this issue Jan 17, 2025
@jfrost-mo
Require tasks to succeed in DEBUG mode
b0a0438 
Fixes #327
jfrost-mo added a commit that referenced this issue Jan 20, 2025
@jfrost-mo
Require tasks to succeed in DEBUG mode
13530c6 
Fixes #327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfrost-mo jfrost-mo

Labels
enhancement New feature or request
Projects
None yet
Milestone
Major usability blockers
Development

Successfully merging a pull request may close this issue.

Require tasks to succeed in DEBUG mode MetOffice/CSET
1 participant
@jfrost-mo