Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap tries to parse start_date, but it's not a required setting #272

Open
edgarrmondragon opened this issue Nov 27, 2024 · 4 comments
Open
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@edgarrmondragon
Copy link
Member

config_start_date = pendulum.parse(self.config["start_date"]).date() # type: ignore[union-attr]
incremental_start_date = pendulum.parse( # type: ignore[union-attr]

Originally reported as #258.

@malikrohail
Copy link

can i fix this

@edgarrmondragon
Copy link
Member Author

can i fix this

Go for it @malikrohail! Do you need anything from me?

@malikrohail
Copy link

i'll set up the env first, and try to understand the codebase. will follow up with you with any follow up question if i hit any blocker

@edgarrmondragon
Copy link
Member Author

i'll set up the env first, and try to understand the codebase. will follow up with you with any follow up question if i hit any blocker

Gotcha, don't hesitate to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants