Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE - Add option to allow "Randomize portrait(s)" context menu to select duplicate portraits #2392

Open
gsparks3 opened this issue Jan 22, 2021 · 0 comments
Labels
Personnel Personnel-related Issues (RFE) Enhancement Requests for Enhancement, new features or implementations

Comments

@gsparks3
Copy link
Collaborator

gsparks3 commented Jan 22, 2021

The right-click context menu option "Randomize portrait(s)" is very useful to easily select portraits for personnel that currently do not have any. Currently it is coded to avoid duplicates, i.e. it will only randomly select portraits that are not already in use for the gender and role of the selected personnel. This makes sense and works fine as long as the number of personnel with the role is less than the number of available portraits.

However, if the number of personnel in a particular role is larger than the number of available portraits, this causes the option to silently fail. Example: I select one of my Vessel Crewmembers that is currently on the default "no portrait". I have enough Vessel Crewmembers that all of the VC portraits are already in use. Using the "Randomize Portrait" context menu option on this personnel simply does nothing, leaving their portrait unselected, with no indication of the cause for this failure.

Either a Campaign Option or MekHQ Option to override the "avoid duplicate random portraits" behavior would fix this issue, although it should be off by default, as the current behavior is reasonable until the number of personnel in the campaign becomes large. It might also be helpful to add something (a pop-up window?) informing the user of the cause of the failure to select a portrait with the "avoid duplicates" behavior active.

@Windchild292 Windchild292 added the (RFE) Enhancement Requests for Enhancement, new features or implementations label Jan 29, 2021
@Windchild292 Windchild292 added the Personnel Personnel-related Issues label Oct 21, 2021
@Windchild292 Windchild292 self-assigned this Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

No branches or pull requests

2 participants