Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams crash when attempting to cancel #48

Open
aryanjassal opened this issue Jan 13, 2025 · 3 comments
Open

Streams crash when attempting to cancel #48

aryanjassal opened this issue Jan 13, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@aryanjassal
Copy link
Member

Describe the bug

When cancelling the web stream using the cancel method, the program crashes with an error saying that readableCancel isn't a valid method - which is weird because doing a console.log(this.readableCancel) returns a valid signature of a function.

This issue was first discovered in Polykey, so the reproduction steps will involve using the application.

To Reproduce

  1. Use a RPC handler method - a duplex stream or a client stream
  2. Cancel the stream
  3. See the error

Expected behavior

The stream should cancel gracefully (while crashing the app works, it is not how it is supposed to cancel the stream)

Logs

Check the comment in additional context for details about the crash and the dissection I performed.

Additional context

Notify maintainers

@CMCDragonkai @tegefaulkes

@aryanjassal aryanjassal added the bug Something isn't working label Jan 13, 2025
Copy link

linear bot commented Jan 13, 2025

@CMCDragonkai
Copy link
Member

Can you write a quick code sample that replicates this.

@CMCDragonkai
Copy link
Member

Even a test that goes into this repo that repros it, as that would prevent regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants