Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x #4

Open
wants to merge 81 commits into
base: 1.2.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
7e9c263
Add item template support: demos
platosha Jan 19, 2017
15787c3
Add item template support: tests
platosha Jan 19, 2017
939089d
Add item template support: implementation
platosha Jan 19, 2017
7b26b80
Add item template support: fix broken tests
platosha Jan 19, 2017
5295499
Add item template support: documentation
platosha Jan 19, 2017
f7ac937
Add item template support: index template property
platosha Jan 20, 2017
9d7ef49
Add item template support: expose selected and focused flags
platosha Jan 20, 2017
49ab767
Merge pull request #376 from vaadin/feature/item-templates
Saulis Jan 23, 2017
66879bd
Improve build (Skeleton PR#13 sync)
Jan 23, 2017
a2947aa
Update package.json and bower.json
Jan 25, 2017
af32d4c
Fix duplicate menu title for item itemplate asciidoc guide
platosha Jan 25, 2017
6cca54a
Merge pull request #378 from vaadin/fix/asciidoc-duplicate-menu-title
limonte Jan 25, 2017
e2fae09
v1.3.0-alpha1
manolo Feb 1, 2017
18b3888
v1.3.0-alpha1 updated package version
manolo Feb 1, 2017
6ad4c1f
Sync with Skeleton (PR#17)
Feb 1, 2017
82b6f41
WCT: webcomponents-lite.js -> webcomponents.js
Feb 2, 2017
5736556
Fix toggling overlay for combo-box-light, fix #380
Feb 1, 2017
63b3e40
Remove angular2 tests
Feb 2, 2017
2395da2
Fix FF tests with focused input
Feb 2, 2017
953491f
Use webcomponents-lite.js for Edge, webcomponentsjs/issues/575
Feb 2, 2017
d8054da
Make dropdown modal by setting body pointer-events: none
Feb 1, 2017
fa65595
Merge pull request #379 from vaadin/feature/modal
limonte Feb 2, 2017
3b452dd
Merge pull request #387 from vaadin/fix/380
limonte Feb 2, 2017
528ca86
Show clear button even if overlay is not shown, fix #238
Feb 3, 2017
456a9eb
Merge branch 'master' into fix/webcomponents.js
limonte Feb 3, 2017
38ad79c
Merge pull request #389 from vaadin/fix/webcomponents.js
limonte Feb 3, 2017
5708a90
Merge pull request #391 from vaadin/fix/238
limonte Feb 3, 2017
41b9ea4
1.3.0-beta1
platosha Feb 7, 2017
075b863
Set hasValue readOnly. Fixes #393
manolo Feb 9, 2017
0ef5647
Add link to item templates in styling doc. Fixes #384
manolo Feb 9, 2017
ab19f19
Merge pull request #394 from vaadin/fix/hasvalue-readonly
platosha Feb 9, 2017
5d8c45a
Merge pull request #397 from vaadin/fix/doc-styling-link
platosha Feb 9, 2017
bd09fdf
Add paper-item demo
tomivirkki Feb 9, 2017
958296c
Add paper-item example to docs
tomivirkki Feb 9, 2017
deab06c
Merge pull request #395 from vaadin/paper-item-demo
platosha Feb 9, 2017
688bedf
Document need of item-label-path in templates. Fixes #381
manolo Feb 9, 2017
03aeabc
Merge pull request #396 from vaadin/fix/doc-item-label-path
platosha Feb 10, 2017
b9609da
Add focus and blur methods, focused property
platosha Feb 9, 2017
96d79df
Merge pull request #398 from vaadin/fix/focus-api
tomivirkki Feb 14, 2017
2041fbd
v1.3.0
Feb 16, 2017
dd57c4c
Update example and live demo in README.md
Feb 9, 2017
31a5e6c
Merge pull request #400 from vaadin/fix/readme-example
limonte Feb 16, 2017
688f7b1
Fix typo in item-template demos
Feb 28, 2017
db93288
Merge pull request #408 from vaadin/fix/item-template-typo
jouni Feb 28, 2017
19408fd
Hide clear icon when disabled or read-only
Saulis Feb 28, 2017
898174b
Merge pull request #409 from vaadin/hide-clear-disabled
platosha Mar 3, 2017
8c0a340
v1.3.1
Saulis Mar 3, 2017
eac6d83
Prevent overriding text when clear icon is shown
web-padawan Mar 3, 2017
2661449
Merge pull request #411 from web-padawan/clear-icon-no-text-override
Saulis Mar 3, 2017
4d9863f
Update package.json
Saulis Mar 3, 2017
a6ca205
Use demo-navigation helper
manolo Mar 16, 2017
dc05d53
Merge pull request #420 from vaadin/feature/navigation
manolo Mar 16, 2017
c341bba
Improve the external filtering example
Mar 16, 2017
4b4ef66
Docs rename 'external-filtering' -> 'filtering'
Mar 16, 2017
9e6ccfe
match -> indexOf
Mar 16, 2017
5820fe3
Merge pull request #421 from vaadin/quick/improve-custom-filtering-ex…
platosha Mar 17, 2017
70989b1
Make `change` event to fire only on close and clear
platosha Mar 13, 2017
8c21bb6
Merge pull request #416 from vaadin/fix/change-event
tomivirkki Mar 20, 2017
1e7b253
Update package.json
tomivirkki Mar 21, 2017
8203514
Adding 2.0 variants
manolo Mar 13, 2017
b7c2034
content -> slot, wrap is=, fix @apply
manolo Mar 14, 2017
e4f2f3c
Fix bower.json to correctly use variants
Mar 15, 2017
ea2bf6e
Applying reviewer suggestions
manolo Mar 24, 2017
6604ca3
Merge pull request #419 from vaadin/feature/use-slots
limonte Mar 31, 2017
26adaa4
Use suffix slot for clear and toggle icons instead of absolute positi…
web-padawan Mar 22, 2017
91daf80
Merge pull request #425 from web-padawan/use-suffix
limonte Mar 31, 2017
3b54f26
Fix custom clear icon tests
Mar 31, 2017
84dff38
Temporary disable Polymer 2 tests, use polymer-cli@next
Mar 31, 2017
2962006
Include subfolders of `demo` and `test` folders for linting
Apr 12, 2017
9168d8e
Fix filtering in iron-list 2.0
manolo May 3, 2017
ade0d12
Add tabindex support. Fixes #401
frami Jun 14, 2017
096352b
Replaced tab to 4 spaces.
frami Jun 14, 2017
3b6b051
Lint check error fixed
frami Jun 14, 2017
9566d5a
Merge pull request #466 from IMSAG/1.x
manolo Jul 25, 2017
b587455
Fix formatting
manolo Jul 25, 2017
1f9da7f
Prevent closing on blur caused by overlay scroller mousedown
platosha Aug 13, 2018
7aeeef0
Merge pull request #699 from vaadin/fix/583
web-padawan Aug 15, 2018
954ae31
SE-1673:- Adds logic to prevent IE scrollbar drag bug.
Sep 19, 2018
b247ce3
Merge pull request #2 from MaritzSTL/SE-1673
terrencebowen Sep 19, 2018
af29675
absolutely position dropdown
jagan-maritz Nov 24, 2020
fec850b
Merge pull request #3 from vaadin/1.x
jay8t6 Mar 24, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@
"extends": "vaadin",
"env": {
"browser": true,
"es6": true,
"node": true
},
"plugins": [
"html"
],
"globals": {
// TODO: remove when moving to ES6 vaadin -> Vaadin
"vaadin": false,
"Vaadin": false,
"Polymer": false,
"CustomElements": false
}
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
bower_components
bower_components*
node_modules
test/angular2/typings
bower-*.json
12 changes: 9 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@ addons:
firefox: latest
google-chrome: latest

script:
install:
- npm install
- polymer install

before_script:
- gulp lint
- travis_retry xvfb-run -s '-screen 0 1024x768x24' wct -l chrome -l firefox
- travis_retry xvfb-run -s '-screen 0 1024x768x24' wct -l chrome -l firefox --dom=shadow
- ([ "$TRAVIS_EVENT_TYPE" = "pull_request" ] || TRAVIS_BRANCH=quick/${TRAVIS_BUILD_ID} xvfb-run -s '-screen 0 1024x768x24' polymer test)

script:
- xvfb-run -s '-screen 0 1024x768x24' wct
37 changes: 31 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
![Bower version](https://img.shields.io/bower/v/vaadin-combo-box.svg)
![Bower version](https://img.shields.io/bower/v/vaadin-combo-box.svg)
[![Published on webcomponents.org](https://img.shields.io/badge/webcomponents.org-published-blue.svg)](https://www.webcomponents.org/element/vaadin/vaadin-combo-box)
[![Build Status](https://travis-ci.org/vaadin/vaadin-combo-box.svg?branch=master)](https://travis-ci.org/vaadin/vaadin-combo-box)
[![Build Status](https://travis-ci.org/vaadin/vaadin-combo-box.svg?branch=master)](https://travis-ci.org/vaadin/vaadin-combo-box)
[![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/vaadin/vaadin-core-elements?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)

# <vaadin-combo-box>
Expand All @@ -14,19 +14,44 @@
<custom-element-demo height="300">
<template>
<script src="../webcomponentsjs/webcomponents-lite.js"></script>
<link rel="import" href="../iron-ajax/iron-ajax.html">
<link rel="import" href="../paper-item/all-imports.html">
<link rel="import" href="vaadin-combo-box.html">
<next-code-block></next-code-block>
</template>
</custom-element-demo>
```
-->
```html
<vaadin-combo-box label="Element"
items='["Cadmium","Caesium","Calcium","Californium","Carbon","Scandium"]'>
</vaadin-combo-box>
<div>
<style is="custom-style">
paper-icon-item {
margin: -13px -16px;
}
paper-icon-item img {
border-radius: 50%;
}
</style>
<template is="dom-bind">
<iron-ajax url="https://randomuser.me/api?results=100&inc=name,email,picture" last-response="{{response}}" auto></iron-ajax>

<vaadin-combo-box items="[[response.results]]" item-value-path="email" item-label-path="email">
<template>
<paper-icon-item>
<img src="[[item.picture.thumbnail]]" item-icon>
<paper-item-body two-line>
<div>[[item.name.first]] [[item.name.last]]</div>
<div secondary>[[item.email]]</div>
</paper-item-body>
</paper-icon-item>
</template>
</vaadin-combo-box>
</template>
</div>

```

[<img src="https://raw.githubusercontent.com/vaadin/vaadin-combo-box/master/docs/img/vaadin-combo-box-overview.png" width="387" alt="Screenshot of vaadin-combo-box" />](https://vaadin.com/elements/-/element/vaadin-combo-box)
[<img src="https://raw.githubusercontent.com/vaadin/vaadin-combo-box/master/docs/img/vaadin-combo-box-item-template-material.png" width="311" alt="Screenshot of vaadin-combo-box" />](https://vaadin.com/elements/-/element/vaadin-combo-box)


## Contributing
Expand Down
83 changes: 60 additions & 23 deletions bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vaadin-combo-box",
"description": "Vaadin Combo Box",
"description": "Polymer element for displaying a list of items with filtering",
"authors": [
"Vaadin Ltd"
],
Expand All @@ -18,30 +18,67 @@
},
"license": "Apache-2.0",
"dependencies": {
"iron-flex-layout": "PolymerElements/iron-flex-layout#^1.0.3",
"iron-form": "polymerelements/iron-form#^1.0.10",
"iron-form-element-behavior": "polymerelements/iron-form-element-behavior#^1.0.4",
"iron-icon": "PolymerElements/iron-icon#^1.0.4",
"iron-iconset-svg": "polymerelements/iron-iconset-svg#^1.0.9",
"iron-input": "polymerelements/iron-input#^1.0.5",
"iron-list": "polymerelements/iron-list#^1.0.0",
"iron-validatable-behavior": "polymerelements/iron-validatable-behavior#^1.0.5",
"paper-button": "polymerelements/paper-button#^1.0.6",
"paper-input": "PolymerElements/paper-input#^1.1.3",
"polymer": "Polymer/polymer#^1.2.0",
"iron-a11y-keys-behavior": "polymerelements/iron-a11y-keys-behavior#^1.0.7",
"iron-resizable-behavior": "polymerelements/iron-resizable-behavior#^1.0.2",
"paper-styles": "polymerelements/paper-styles#^1.1.2",
"iron-a11y-announcer": "polymerelements/iron-a11y-announcer#^1.0.4",
"paper-icon-button": "polymerelements/paper-icon-button#^1.0.5"
"polymer": "^1.7.0",
"iron-flex-layout": "^1.0.0",
"iron-form": "^1.0.0",
"iron-form-element-behavior": "^1.0.0",
"iron-icon": "^1.0.0",
"iron-iconset-svg": "^1.0.0",
"iron-input": "^1.0.0",
"iron-list": "^1.0.0",
"iron-validatable-behavior": "^1.0.0",
"paper-button": "^1.0.0",
"paper-input": "^1.0.0",
"iron-a11y-keys-behavior": "^1.0.0",
"iron-resizable-behavior": "^1.0.0",
"paper-styles": "^1.0.0",
"iron-a11y-announcer": "^1.0.0",
"paper-icon-button": "^1.0.0"
},
"devDependencies": {
"elements-demo-resources": "vaadin/elements-demo-resources#master",
"iron-ajax": "^1.0.0",
"iron-component-page": "^1.0.0",
"iron-demo-helpers": "^1.0.0",
"iron-form": "^1.0.0",
"iron-icons": "^1.0.0",
"iron-test-helpers": "^1.0.0",
"paper-item": "^1.0.0",
"web-component-tester": "^5.0.0",
"test-fixture": "polymerelements/test-fixture#^1.0.0",
"iron-test-helpers": "polymerelements/iron-test-helpers#^1.0.0",
"iron-component-page": "polymerelements/iron-component-page#^1.1.0",
"iron-icons": "PolymerElements/iron-icons#^1.0.3",
"iron-demo-helpers": "polymerelements/iron-demo-helpers#^1.0.0",
"elements-demo-resources": "vaadin/elements-demo-resources#master"
"webcomponentsjs": "^0.7.23"
},
"variants": {
"polymer2": {
"dependencies": {
"polymer": "^2.0.0-rc.2",
"iron-flex-layout": "#2.0-preview",
"iron-form": "#2.0-preview",
"iron-form-element-behavior": "#2.0-preview",
"iron-icon": "#2.0-preview",
"iron-iconset-svg": "#2.0-preview",
"iron-input": "#2.0-preview",
"iron-list": "#2.0-preview",
"iron-validatable-behavior": "#2.0-preview",
"paper-button": "#2.0-preview",
"paper-input": "#2.0-preview",
"iron-a11y-keys-behavior": "#2.0-preview",
"iron-resizable-behavior": "#2.0-preview",
"paper-styles": "#2.0-preview",
"iron-a11y-announcer": "#2.0-preview",
"paper-icon-button": "#2.0-preview"
},
"devDependencies": {
"elements-demo-resources": "vaadin/elements-demo-resources#2.0-preview",
"iron-ajax": "#2.0-preview",
"iron-component-page": "#2.0-preview",
"iron-demo-helpers": "#2.0-preview",
"iron-form": "#2.0-preview",
"iron-icons": "#2.0-preview",
"iron-test-helpers": "#2.0-preview",
"paper-item": "#2.0-preview",
"web-component-tester": "6.0.0-prerelease.7",
"webcomponentsjs": "#v1"
}
}
}
}
5 changes: 3 additions & 2 deletions demo/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
},
"globals": {
"elements": false,
"elementsJson": false
"users": false,
"elementsJson": false,
"HTMLImports": false
}
}

9 changes: 1 addition & 8 deletions demo/advanced.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,7 @@

<body unresolved>
<div class="vertical-section-container centered">
<nav class="vertical-section">
<ul class="layout horizontal wrap">
<li><a href="index.html">Basic Examples</a></li>
<li><a href="objects.html">Object Items</a></li>
<li><b>Advanced Usage</b></li>
<li><a href="external-filtering.html">Remote and Custom Filtering</a></li>
</ul>
</nav>
<demo-navigation></demo-navigation>

<h3>Typing Custom Values</h3>

Expand Down
Loading