Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay Closing Logic Faulty #283

Open
ryuhhnn opened this issue Jan 13, 2020 · 0 comments
Open

Overlay Closing Logic Faulty #283

ryuhhnn opened this issue Jan 13, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@ryuhhnn
Copy link
Contributor

ryuhhnn commented Jan 13, 2020

Describe the bug
The logic for closing overlays will fail whenever there are multiple of the same element on the page. The affected elements include:

  • Timezone
  • Select
  • Multiselect
  • Date

To Reproduce
Steps to reproduce the behavior:
Add two of any of the above elements to a page, open one, and then select the other. You should see that both overlays open at the same time and clicking anywhere on the page will close them both simultaniously.

Expected behavior
Elements with overlays should open/close independently.

Possible Solution
Add a unique ID to each instance of the element, and check in the click handler for that ID, instead of simply the tag name

@ryuhhnn ryuhhnn added the bug Something isn't working label Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant