We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread.setDaemon
When running tests (make test), there is a DeprecationWarning on the setDaemon method (class threading.Thread):
make test
DeprecationWarning
setDaemon
threading.Thread
tests/test_browser.py .. [ 33%] tests/test_events.py ... [ 83%] tests/test_markdown.py . [100%] ======================================================================== warnings summary ========================================================================= tests/test_events.py::test_message_posted_event_initialization tests/test_events.py::test_message_edited_event_initialization tests/test_events.py::test_message_starred_event_initialization /.../ChatExchange/chatexchange/client.py:101: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self._thread.setDaemon(True) -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html ================================================================== 6 passed, 3 warnings in 0.58s ==================================================================
It is better to use thread.daemon = True instead of thread.setDaemon(True).
thread.daemon = True
thread.setDaemon(True)
Note: the daemon attribute was added in Python 2.6
daemon
PR: #183
The text was updated successfully, but these errors were encountered:
The pull request was merged, so I'm closing this issue.
Sorry, something went wrong.
No branches or pull requests
When running tests (
make test
), there is aDeprecationWarning
on thesetDaemon
method (classthreading.Thread
):It is better to use
thread.daemon = True
instead ofthread.setDaemon(True)
.PR: #183
The text was updated successfully, but these errors were encountered: