-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Improvement request: Favorites / most used emojis as default #42
Comments
I'm glad to hear it! Sadly, since this is a plugin to Rofi instead of a script that wraps Rofi, we're limited to the very small API that Rofi exposes. For example:
What we could do is build our own parallell config file to be placed under It's all pretty hacky really, and will never be super comfortable to use. I think I would recommend anyone that wants features like this to do so by wrapping Rofi in a script, where this plugin could act as a data source of some sort. Then the only thing that is really required here is probably to make it easier to swap in other Emoji data files. So, to summarize:
I'll open up an issue detailing what I think this plugin should add to make this easier for people like you. :-) |
See #43 |
Thanks to you I had another look through Rofi's header files and found out a lot of features in their Plugin API that I wasn't aware of. This was the basis for my rework into version 3: #44. I suspect with the foundation inside there that we could add real "favorites" functionality in the plugin proper, but it's going to be a bit further along. |
Amazing!
Mvh
Kenneth Bæver Bjerke
+47 966 21 811
…On Fri, Jul 1, 2022 at 1:31 AM Magnus Bergmark ***@***.***> wrote:
Thanks to you I had another look through Rofi's header files and found out
a lot of features in their Plugin API that I wasn't aware of.
This was the basis for my rework into version 3: #44
<#44>.
I suspect with the foundation inside there that we could add real
"favorites" functionality in the plugin proper, but it's going to be a bit
further along.
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7OB5ZEZ6KYGGY2WNZ5TCLVRYU5HANCNFSM5YJVNUYA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hi,
I'm still just an aspiring programmer myself, so can't really put up a pull request or anything.. But Here's a thing I would love to see in this plugin.
Either or:
and/or
I just started using this, so this is coming from very fresh (and very happy!) eyes, after wathing the LInuxCast episode just now.
The text was updated successfully, but these errors were encountered: