Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Improvement request: Favorites / most used emojis as default #42

Open
DiggsAsura opened this issue Jun 9, 2022 · 4 comments
Open

Comments

@DiggsAsura
Copy link

Hi,

I'm still just an aspiring programmer myself, so can't really put up a pull request or anything.. But Here's a thing I would love to see in this plugin.

Either or:

  1. Sort after usage (favorites)
    and/or
  2. Make lists of favs, which then will be default

I just started using this, so this is coming from very fresh (and very happy!) eyes, after wathing the LInuxCast episode just now.

@DiggsAsura DiggsAsura changed the title Feature/Improvement request :-) Feature/Improvement request: Favoriets/most used emojis as default Jun 9, 2022
@Mange
Copy link
Owner

Mange commented Jun 11, 2022

I'm glad to hear it!

Sadly, since this is a plugin to Rofi instead of a script that wraps Rofi, we're limited to the very small API that Rofi exposes.

For example:

  • Rofi tracks history for the app launcher, but only for the app launcher, not for any plugins.
  • We're not able to accept any configuration, either runtime through CLI arguments or config files through Rofi.

What we could do is build our own parallell config file to be placed under .config/rofi/rofi-emoji and use that for certain settings. We could also respond to environment variables instead of CLI arguments in order to toggle some things.

It's all pretty hacky really, and will never be super comfortable to use. I think I would recommend anyone that wants features like this to do so by wrapping Rofi in a script, where this plugin could act as a data source of some sort. Then the only thing that is really required here is probably to make it easier to swap in other Emoji data files.

So, to summarize:

  • Your wishlist is not something we can do inside this project realistically.
  • We could make this plugin easier to use in a wrapping script.
  • Adding wrapping scripts to this repo as a good starting point for people to build their own scripts is workable.

I'll open up an issue detailing what I think this plugin should add to make this easier for people like you. :-)

@Mange
Copy link
Owner

Mange commented Jun 11, 2022

See #43

@Mange Mange closed this as completed Jun 11, 2022
@Mange
Copy link
Owner

Mange commented Jun 30, 2022

Thanks to you I had another look through Rofi's header files and found out a lot of features in their Plugin API that I wasn't aware of.

This was the basis for my rework into version 3: #44.

I suspect with the foundation inside there that we could add real "favorites" functionality in the plugin proper, but it's going to be a bit further along.

@Mange Mange reopened this Jun 30, 2022
@DiggsAsura
Copy link
Author

DiggsAsura commented Jun 30, 2022 via email

@Mange Mange changed the title Feature/Improvement request: Favoriets/most used emojis as default Feature/Improvement request: Favorites / most used emojis as default Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants