Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename button #3877 #3906

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rename button #3877 #3906

wants to merge 2 commits into from

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Jan 31, 2025

Rename "Reset camera when changing map" button

Closes: #3877

Description

To make it more clear when the camera is actually reset

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@BenediktMehl BenediktMehl force-pushed the feat/3877/rename-a-button branch from 60a1ef5 to ca44e7c Compare January 31, 2025 15:52
Copy link

Copy link

Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and clean 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset camera when changing map should be easier to understand
2 participants