Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Logo looks squished #340

Open
CodeWithShreyans opened this issue Dec 30, 2024 · 5 comments
Open

Apple Logo looks squished #340

CodeWithShreyans opened this issue Dec 30, 2024 · 5 comments

Comments

@CodeWithShreyans
Copy link

Describe the bug
The Apple Logo ASCII art looks weirdly compacted and squished.

To Reproduce
Steps to reproduce the behavior:

  1. Use macchina on a mac.

Expected behavior
It has a normal aspect ratio.

Screenshots
image

macchina --doctor output

We've collected a total of 19 readouts including 2 failed read(s) and 1 read(s) resulting in a warning.

Readout "LocalIP" failed with message: Unable to get local IPv4 address.
Readout "GPU" failed with message: This metric is not available on this platform or is not yet implemented by libmacchina.

1 of the 3 unsuccessful read(s) resulted in a warning:
 Readout "Distribution" threw a warning with message: Since you're on macOS, there is no distribution to be read from the system.
@grtcdr
Copy link
Member

grtcdr commented Dec 30, 2024

I don't see any squishiness...

Perhaps you could provide an example by overlaying the original Apple logo and our ASCII version.

@CodeWithShreyans
Copy link
Author

image

Maybe something like this would be better:
image jpeg bd3952ad7d87d5ce184a7da6b832ab37

@grtcdr
Copy link
Member

grtcdr commented Dec 31, 2024

Feel free to make a pull request, the relevant section is the following:

macchina/src/ascii.rs

Lines 86 to 105 in e7da330

pub(crate) fn get_ascii_art(size: AsciiSize) -> Vec<Text<'static>> {
match size {
AsciiSize::Big => {
let art: Vec<Span> = vec![
Span::styled(" ,MMMM.", *GREEN),
Span::styled(" .MMMMMM", *GREEN),
Span::styled(" MMMMM,", *GREEN),
Span::styled(" .;MMMMM:' MMMMMMMMMM;.", *YELLOW),
Span::styled(" MMMMMMMMMMMMNWMMMMMMMMMMM:", *YELLOW),
Span::styled(" .MMMMMMMMMMMMMMMMMMMMMMMMWM.", *YELLOW),
Span::styled(" MMMMMMMMMMMMMMMMMMMMMMMMM.", *RED),
Span::styled(";MMMMMMMMMMMMMMMMMMMMMMMM:", *RED),
Span::styled(":MMMMMMMMMMMMMMMMMMMMMMMM:", *RED),
Span::styled(".MMMMMMMMMMMMMMMMMMMMMMMMM.", *MAGENTA),
Span::styled(" MMMMMMMMMMMMMMMMMMMMMMMMMMM.", *MAGENTA),
Span::styled(" .MMMMMMMMMMMMMMMMMMMMMMMMMM.", *MAGENTA),
Span::styled(" MMMMMMMMMMMMMMMMMMMMMMMM", *BLUE),
Span::styled(" ;MMMMMMMMMMMMMMMMMMMM.", *BLUE),
Span::styled(" .MMMM,. .MMMM,.", *BLUE),
];

@CodeWithShreyans
Copy link
Author

gonna try!

@CodeWithShreyans
Copy link
Author

does it need to be a specific length and/or width?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants