Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we represent SE creations? #9

Open
WalterSimoncini opened this issue Feb 19, 2021 · 1 comment
Open

How should we represent SE creations? #9

WalterSimoncini opened this issue Feb 19, 2021 · 1 comment
Labels
question Further information is requested

Comments

@WalterSimoncini
Copy link
Collaborator

In the database schema, we have the is_se field, which indicates whether a transaction concerns the creation of an SE company. According to the excel sheet an SE can be created via merger, conversion, holding-SE, subsidiary-SE, or unsure when this information is unknown.

Would it make sense to represent this information via the transaction's class (aka type) by classifying these transactions as "SECreation" with the following subclasses?

  • SECreationConversion
  • SECreationHolding
  • SECreationMerger
  • SECreationSubsidiary

And when we do not know the SE creation subtype (equivalent to "unsure") we would assign the umbrella class "SECreation".

This structure could allow users to write more expressive queries (instead of querying on the boolean is_se and the se_type fields), what are your thoughts on this?

@WalterSimoncini WalterSimoncini added the question Further information is requested label Feb 20, 2021
@kodymoodley
Copy link
Contributor

Thanks @WalterSimoncini , I defer this issue to @marcus-meyer-maas and @pedrohserrano . They indicated that this is an important issue to resolve. Let's hear their thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants