Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model for acquisition/merger dynamics may be problematic #7

Open
micheldumontier opened this issue Aug 19, 2020 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@micheldumontier
Copy link

The use of indiscriminate predicates (e.g. involves) to point to individuals (e.g. a specific company) that are assigned role-based types (e.g. Acquiring company, Merging company) will fail as soon as one company is involved in both a merger and an acquisition (are part of different company transactions) - as they will be typed as both "Acquiring Company" and "Merging Company" and it won't be clear what role it had in either transaction. You can avoid this problem by either using specific predicates in the transaction (e.g. "has-acquisition-company" "has-merging-company"), or use transaction-unique instantiated roles ( involves some ('acquisition role'|'merging role' that 'is role of' some 'company').

@micheldumontier micheldumontier added the bug Something isn't working label Aug 19, 2020
@kodymoodley
Copy link
Contributor

The point about using more specific predicates than 'involves' is super useful! Given the queries we want to ask about mergers and acquisitions, it is indeed important to agree on these sub-predicates. @marcus-meyer-maas I will fix this for the next release. As @micheldumontier says, "has-acquisition-company" "has-merging-company" are good places to start.

@kodymoodley kodymoodley pinned this issue Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants