[Edge Case] Handle the Empty file Upload

[ksdkamesh99]

If the user uploads an empty file then it should stop the upload and send an alert to the user stating that the uploaded file is empty.

[elleanne]

I would like to work on this issue!
It looks like what you're talking about is line 52 in Dashboard/dashboard.jsx, const captureFile = (files, event) => ?
Or is it line 74, const onSubmit = async (event) => { ?

[Sameerkash]

@Eliboss, sure please go ahead, I think this could be accomplished while the file is captured, you can read the contents of the file, similar code is available here

CryptoDrive/src/pages/Login/index.jsx

Line 44 in 3818aa7

function readkeyFile(file) {

so you could similarly read the file, or compare its size and ensure it's not 0 bytes. and then send an alert and return.

[elleanne]

Awesome, I'll work on it today!

[elleanne]

I tried signing up both locally and on your deployed site so I could test this issue. The same issue occurred on both host sites, shown below.

Does this have to do with adding a local host network to MetaMask?

Locally

Deployed

[elleanne]

Update: I was able to upload a .pem file on the signin page without having an account (Though, of course, couldn't cont. past that page)
The alert worked when the .pem file had no text in it

[ksdkamesh99]

@Eliboss Thanks for solving the issue. If you want to upload any file then metamask is needed in each timestep. The issue is not for only pem file it's about the files in drag and drop as well

[elleanne]

ah, ok. It sent me an alert that only .pem files could be uploaded on the signin page. If I need to check the drop in drag, Ill need a login. But I was having issues with that (see above comment). If you can get me connected to that, Ill look at it tomorrow.

[Sameerkash]

ah, ok. It sent me an alert that only .pem files could be uploaded on the sign-in page. If I need to check the drop-in drag, I'll need a login. But I was having issues with that (see above comment). If you can get me connected to that, I'll look at it tomorrow.

@Eliboss mostly looks like a meta mask error, do you have MetaMask extension installed?

[ksdkamesh99]

ok @Eliboss
As this is an edge case and it needs to be fixed asap there are 2 options with us. One to make you understand the metamask one or the maintainer team need to solve it asap. Kindly respond in our discord channel.

[ksdkamesh99]

@Eliboss One more thing is you should not make any PR to main. Any PR should be made to staging as per the guidelines.

[elleanne]

@ksdkamesh99 I dont see your discord link anywhere. Can you send it to me?

[Priyanshu-official]

@Eliboss https://discord.com/invite/BKgbJFS4Kf