Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong EconomizerType entry name in Basilisk.Core.EnconomizerType #32

Open
samuelduchesne opened this issue Jul 24, 2019 · 0 comments
Open

Comments

@samuelduchesne
Copy link
Member

samuelduchesne commented Jul 24, 2019

Let's say one would modify manually an UmiTemplate JSON and set the EconomizerType to "DifferentialEnthalpy", the Template Editor will fail to open the template library without much debugging info.

Running Basilisk in Debug mode allowed me to inspect the Exception thrown by NewtownSoft.Json:

"Error converting value \"DifferentialEnthalpy\" to type 'Basilisk.Core.EconomizerType'. Path 'ZoneConditionings[0].EconomizerType', line 2197, position 46."

Then, looking at Basilisk.Core.EconomizerType, we can see that the culprit is an "h" in "DifferentialEnthalphy".

namespace Basilisk.Core
{
    public enum EconomizerType
    {
        NoEconomizer,
        DifferentialDryBulb,
        DifferentialEnthalphy
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant