Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sized flag logic #99

Open
argonaut22 opened this issue Nov 4, 2024 · 1 comment
Open

Improve sized flag logic #99

argonaut22 opened this issue Nov 4, 2024 · 1 comment

Comments

@argonaut22
Copy link
Collaborator

@argonaut22 added a field to the aircraft struct to indicate if a model is sized. Right now it's v naive (namely, reaching the end of wsize).

We should figure out how to do this more robustly (e.g., not setting ac.sized = True if wsize() doesn't converge or if a driving parameter is changed [this may depend on determining "design parameters"])

@ngomezve
Copy link
Contributor

ngomezve commented Nov 4, 2024

This is a very good idea, @argonaut22. In my code, I artificially set some fields to NaN if the sizing fails, but an approach such as this is much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants