Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mission() has initeng = 0 #72

Open
ngomezve opened this issue Jul 31, 2024 · 1 comment
Open

mission() has initeng = 0 #72

ngomezve opened this issue Jul 31, 2024 · 1 comment

Comments

@ngomezve
Copy link
Contributor

Why does initeng = 0 in mission? This tells tfoper to start every Newton iteration from scratch. If it were 1, it would take the result of the previous sizing iteration as the starting point.
@ngomezve
Copy link
Contributor Author

ngomezve commented Nov 8, 2024

I just did some benchmarking and it looks like changing the above to initeng = 1 can reduce the number of allocations of aircraft of all classes, and speedups in all cases except for hydrogen (unclear why).

Median t (ms) initeng = 0 Median t (ms) initeng = 1 Allocs initeng = 0 Allocs initeng = 1
Default 240.710 178.266 7109530 5155184
Regional 229.980 179.963 7126264 5187507
Wide 282.201 243.141 9132586 7022862
Hydrogen 1205 1253 29245689 26342920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngomezve