Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload-Range capabilities need updating #106

Open
1 of 5 tasks
argonaut22 opened this issue Nov 17, 2024 · 3 comments
Open
1 of 5 tasks

Payload-Range capabilities need updating #106

argonaut22 opened this issue Nov 17, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@argonaut22
Copy link
Collaborator

argonaut22 commented Nov 17, 2024

Updated after rediscovering the outputs.jl PayloadRange():

steps to bring the function to best practices:

  • create new tests to ensure fixes for future PRs
  • Update plotting to use Plots.jl (done in branch: argonaut22/plot_redux)
  • can we do better* than try-catching any error that gets thrown? the effect with this handling is that any breaking gets hidden and a 0-range diagram is produced with little indication of what went wrong.

With PayloadRange(), we can probably delete example_PRD.jl and PRD_input.toml. If we somehow wanted to keep it, the following would need to be done, since it's currently broken:

  • update PRD_input.toml to match the new max_pax nomenclature, and aircraft_type field
  • why does the PRD toml example specify 5 missions?

*we should do better 😬

@argonaut22 argonaut22 added the bug Something isn't working label Nov 17, 2024
@argonaut22
Copy link
Collaborator Author

Update! found the version in outputs.jl. adjusted tasks accordingly

@ngomezve ngomezve self-assigned this Dec 6, 2024
@ngomezve
Copy link
Contributor

ngomezve commented Dec 6, 2024

I'll fix this in my PR for off-design missions. The PayloadRange() function is quite outdated and requires some specific aircraft objects (e.g., it cannot have just one mission).

@argonaut22
Copy link
Collaborator Author

Fun new issue: running PayloadRange on an aircraft with only one mission does not work (tries to set ac.parm[imRange,2] when ac.parm is only a Vector). Can replicate with the example_cryo.jl model.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants