You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updated after rediscovering the outputs.jl PayloadRange():
steps to bring the function to best practices:
create new tests to ensure fixes for future PRs
Update plotting to use Plots.jl (done in branch: argonaut22/plot_redux)
can we do better* than try-catching any error that gets thrown? the effect with this handling is that any breaking gets hidden and a 0-range diagram is produced with little indication of what went wrong.
With PayloadRange(), we can probably delete example_PRD.jl and PRD_input.toml. If we somehow wanted to keep it, the following would need to be done, since it's currently broken:
update PRD_input.toml to match the new max_pax nomenclature, and aircraft_type field
why does the PRD toml example specify 5 missions?
*we should do better 😬
The text was updated successfully, but these errors were encountered:
I'll fix this in my PR for off-design missions. The PayloadRange() function is quite outdated and requires some specific aircraft objects (e.g., it cannot have just one mission).
Fun new issue: running PayloadRange on an aircraft with only one mission does not work (tries to set ac.parm[imRange,2] when ac.parm is only a Vector). Can replicate with the example_cryo.jl model.
Updated after rediscovering the outputs.jl
PayloadRange()
:steps to bring the function to best practices:
With PayloadRange(), we can probably delete
example_PRD.jl
andPRD_input.toml
. If we somehow wanted to keep it, the following would need to be done, since it's currently broken:PRD_input.toml
to match the new max_pax nomenclature, and aircraft_type field*we should do better 😬
The text was updated successfully, but these errors were encountered: