From f7e4c08f36c72367b9fa002d6320bd2a43535c32 Mon Sep 17 00:00:00 2001 From: Gai Samuel Date: Fri, 10 Jan 2025 19:04:48 +0300 Subject: [PATCH 1/8] Added first part of the retrospective. --- collaboration/retrospective.md | 36 +++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/collaboration/retrospective.md b/collaboration/retrospective.md index 74e18813b..6bd9ae74d 100644 --- a/collaboration/retrospective.md +++ b/collaboration/retrospective.md @@ -1,23 +1,37 @@ -# Retrospective +# Retrospective :rewind: -## Stop Doing +“_Regardless of what we discover, we understand and truly believe that everyone did the best job they could, given what they knew at the time, their skills and abilities, the resources available, and the situation at hand._” __NORM KERTH.__ -## Continue Doing +__*Over the past weeks, our group embarked on the journey of learning and practicing effective code reviews. This retrospective aims to reflect on our experiences, evaluate what went well, identify areas for improvement, and outline actionable steps to enhance our skills further. By reviewing our process and establishing the best practices for future code reviews, we hope to foster a collaborative environment.*__ -## Start Doing +## Stop doing :no_good: -## Lessons Learned + 1. Stop merging changes without proper reviews. -______________________________________________________________________ +## Continue doing :thumbsup: -## Strategy vs. Board + 1. Regular code reviews. + 2. Helping each other out to ensure no one is left behind. + 3. Carrying out regular video calls + 4. Being active in the group + 5. Automated testing for critical features + 6. Setting clear deadlines for deliverables + 7. Sharing resources and insights to improve team knowledge and skills collectively. -### What parts of your plan went as expected? +## Start doing :rocket: -### What parts of your plan did not work out? + 1. __Conducting regular check-ins to align on progress and adjust priorities as needed.__ + 2. __Tracking and addressing recurring issues__; _We noticed that some issues, like not using descriptive enough names for variables (e.g., naming a variable s instead of binary_str), kept coming up during our reviews. To avoid making the same mistakes as a group and having to point them out individually each time, we plan to keep a shared list of these common issues. This way, everyone can see and remember them, helping us improve and use better practices in future projects._ -### Did you need to add things that weren't in your strategy? +## Lessons Learned :mortar_board: -### Or remove extra steps? +1. __Importance of clear communication and task assignment__ +2. __Benefits of automated testing and continuous integration__ +3. __Value of regular team feedback and retrospectives__ +4. __The importance of role clarity__: _Assigning clear roles in each review cycle (e.g., reviewer, author, maintainer) ensures accountability and smoothens the workflow_. +5. __The value of iterative learning__: _Every mistake or challenge faced during this process offered an opportunity to grow and refine our practices._ +6. __Effective prioritization leads to efficiency__: _Focus on the most impactful changes during reviews to optimize time and effort._ + +--- From 6bb04ab70c2dba901f164345c0add55373e53b69 Mon Sep 17 00:00:00 2001 From: Gai Samuel Date: Fri, 10 Jan 2025 20:43:41 +0300 Subject: [PATCH 2/8] Corrected formatting. --- collaboration/retrospective.md | 32 +++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/collaboration/retrospective.md b/collaboration/retrospective.md index 6bd9ae74d..a53ecaec2 100644 --- a/collaboration/retrospective.md +++ b/collaboration/retrospective.md @@ -2,9 +2,16 @@ # Retrospective :rewind: -“_Regardless of what we discover, we understand and truly believe that everyone did the best job they could, given what they knew at the time, their skills and abilities, the resources available, and the situation at hand._” __NORM KERTH.__ +“_Regardless of what we discover, we understand and truly believe that everyone + did the best job they could, given what they knew at the time, their skills and + abilities, the resources available, and the situation at hand._” __NORM KERTH.__ -__*Over the past weeks, our group embarked on the journey of learning and practicing effective code reviews. This retrospective aims to reflect on our experiences, evaluate what went well, identify areas for improvement, and outline actionable steps to enhance our skills further. By reviewing our process and establishing the best practices for future code reviews, we hope to foster a collaborative environment.*__ +__*Over the past weeks, our group embarked on the journey of learning and + practicing effective code reviews. This retrospective aims to reflect on our + experiences, evaluate what went well, identify areas for improvement, and + outline actionable steps to enhance our skills further. By reviewing our + process and establishing the best practices for future code reviews, we hope + to foster a collaborative environment.*__ ## Stop doing :no_good: @@ -22,16 +29,27 @@ __*Over the past weeks, our group embarked on the journey of learning and practi ## Start doing :rocket: - 1. __Conducting regular check-ins to align on progress and adjust priorities as needed.__ - 2. __Tracking and addressing recurring issues__; _We noticed that some issues, like not using descriptive enough names for variables (e.g., naming a variable s instead of binary_str), kept coming up during our reviews. To avoid making the same mistakes as a group and having to point them out individually each time, we plan to keep a shared list of these common issues. This way, everyone can see and remember them, helping us improve and use better practices in future projects._ + 1. __Conducting regular check-ins to align on progress and adjust priorities + as needed.__ + 2. __Tracking and addressing recurring issues__; _We noticed that some issues, + like not using descriptive enough names for variables (e.g., naming a + variable s instead of binary_str), kept coming up during our reviews. To + avoid making the same mistakes as a group and having to point them out + individually each time, we plan to keep a shared list of these common + issues. This way, everyone can see and remember them, helping us improve + and use better practices in future projects._ ## Lessons Learned :mortar_board: 1. __Importance of clear communication and task assignment__ 2. __Benefits of automated testing and continuous integration__ 3. __Value of regular team feedback and retrospectives__ -4. __The importance of role clarity__: _Assigning clear roles in each review cycle (e.g., reviewer, author, maintainer) ensures accountability and smoothens the workflow_. -5. __The value of iterative learning__: _Every mistake or challenge faced during this process offered an opportunity to grow and refine our practices._ -6. __Effective prioritization leads to efficiency__: _Focus on the most impactful changes during reviews to optimize time and effort._ +4. __The importance of role clarity__: _Assigning clear roles in each review + cycle (e.g., reviewer, author, maintainer) ensures accountability and + smoothens the workflow_. +5. __The value of iterative learning__: _Every mistake or challenge faced during + this process offered an opportunity to grow and refine our practices._ +6. __Effective prioritization leads to efficiency__: _Focus on the most + impactful changes during reviews to optimize time and effort._ --- From 71b6fb87a7a1380c37478be687309ca0969d5a66 Mon Sep 17 00:00:00 2001 From: Gai Samuel Date: Fri, 10 Jan 2025 22:32:57 +0300 Subject: [PATCH 3/8] Fixing formatting --- collaboration/retrospective.md | 62 +++++++++++++++++----------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/collaboration/retrospective.md b/collaboration/retrospective.md index a53ecaec2..abb56fbb5 100644 --- a/collaboration/retrospective.md +++ b/collaboration/retrospective.md @@ -1,23 +1,23 @@ -# Retrospective :rewind: +# Retrospective ⏪ “_Regardless of what we discover, we understand and truly believe that everyone - did the best job they could, given what they knew at the time, their skills and - abilities, the resources available, and the situation at hand._” __NORM KERTH.__ +did the best job they could, given what they knew at the time, their skills and +abilities, the resources available, and the situation at hand._” __NORM KERTH.__ -__*Over the past weeks, our group embarked on the journey of learning and - practicing effective code reviews. This retrospective aims to reflect on our - experiences, evaluate what went well, identify areas for improvement, and - outline actionable steps to enhance our skills further. By reviewing our - process and establishing the best practices for future code reviews, we hope - to foster a collaborative environment.*__ +___Over the past weeks, our group embarked on the journey of learning and +practicing effective code reviews. This retrospective aims to reflect on our +experiences, evaluate what went well, identify areas for improvement, and +outline actionable steps to enhance our skills further. By reviewing our +process and establishing the best practices for future code reviews, we hope +to foster a collaborative environment.___ -## Stop doing :no_good: +## Stop doing 🙅‍♂️ 1. Stop merging changes without proper reviews. -## Continue doing :thumbsup: +## Continue doing 👍 1. Regular code reviews. 2. Helping each other out to ensure no one is left behind. @@ -27,29 +27,29 @@ __*Over the past weeks, our group embarked on the journey of learning and 6. Setting clear deadlines for deliverables 7. Sharing resources and insights to improve team knowledge and skills collectively. -## Start doing :rocket: +## Start doing 🚀 1. __Conducting regular check-ins to align on progress and adjust priorities as needed.__ 2. __Tracking and addressing recurring issues__; _We noticed that some issues, - like not using descriptive enough names for variables (e.g., naming a - variable s instead of binary_str), kept coming up during our reviews. To - avoid making the same mistakes as a group and having to point them out - individually each time, we plan to keep a shared list of these common - issues. This way, everyone can see and remember them, helping us improve - and use better practices in future projects._ - -## Lessons Learned :mortar_board: - -1. __Importance of clear communication and task assignment__ -2. __Benefits of automated testing and continuous integration__ -3. __Value of regular team feedback and retrospectives__ -4. __The importance of role clarity__: _Assigning clear roles in each review - cycle (e.g., reviewer, author, maintainer) ensures accountability and - smoothens the workflow_. -5. __The value of iterative learning__: _Every mistake or challenge faced during - this process offered an opportunity to grow and refine our practices._ -6. __Effective prioritization leads to efficiency__: _Focus on the most - impactful changes during reviews to optimize time and effort._ + like not using descriptive enough names for variables (e.g., naming a + variable s instead of binary_str), kept coming up during our reviews. To + avoid making the same mistakes as a group and having to point them out + individually each time, we plan to keep a shared list of these common + issues. This way, everyone can see and remember them, helping us improve + and use better practices in future projects._ + +## Lessons Learned 🎓 + + 1. __Importance of clear communication and task assignment__ + 2. __Benefits of automated testing and continuous integration__ + 3. __Value of regular team feedback and retrospectives__ + 4. __The importance of role clarity__: _Assigning clear roles in each review + cycle (e.g., reviewer, author, maintainer) ensures accountability and + smoothens the workflow_. + 5. __The value of iterative learning__: _Every mistake or challenge faced during + this process offered an opportunity to grow and refine our practices._ + 6. __Effective prioritization leads to efficiency__: _Focus on the most + impactful changes during reviews to optimize time and effort._ --- From 12f4c5948c5f1982c10928e889324ab461fca4c4 Mon Sep 17 00:00:00 2001 From: yonatanbest Date: Sat, 11 Jan 2025 18:43:55 +0300 Subject: [PATCH 4/8] Strategy vs. Board added --- collaboration/retrospective.md | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/collaboration/retrospective.md b/collaboration/retrospective.md index abb56fbb5..ca66a93bb 100644 --- a/collaboration/retrospective.md +++ b/collaboration/retrospective.md @@ -53,3 +53,37 @@ to foster a collaborative environment.___ impactful changes during reviews to optimize time and effort._ --- + +## Strategy vs. Board + +### What parts of your plan went as expected? 👍 + +1. __Improved understanding of code-reviewing principles__; _Throughout this pro + ject, we gained a deeper understanding of the importance of code-reviewing an + d how to apply best practices._ +2. __Effective collaboration__; _Group members worked well together, providing c + onstructive feedback and supporting each other in the learning process which + allowed us to refine our approach and improve both our coding practices and c + ommunication. This made the code review process not only more effective but a + lso more rewarding, as we could see visible improvements over time._ +3. __Keeping deadlines on track and the delivery of work as expected.__ + +### What parts of your plan did not work out? 👎 + + 1. __Initial struggle with code review tools__; _We faced some challenges get + ting familiar with the code review tools, but eventually got the hang of it._ + 2. __We weren't quite able to fully help each other out as a colleague of our + s decided not to continue with the program.__ + +### Did you need to add things that weren’t in your strategy? 🤔 + + 1. __Dedicated Learning Time for Tools__; _Some team members needed more time + to learn and practice using tools like GitHub and setting up the environment + . While we helped each other whenever needed during our meetings, it would h + ave saved time if we had set aside time specifically for learning the tools. + This could have been done either together in a session at the beginning or + by giving everyone extra time upfront to get familiar with the tools. Exte + nding the deadlines a bit would also have helped everyone feel more comforta + ble and avoided early delays._ + +### Or remove extra steps? 🚮 From 68e591d53107e908c1c42b2c1ad63345e0f600da Mon Sep 17 00:00:00 2001 From: yonatanbest Date: Sat, 11 Jan 2025 18:46:18 +0300 Subject: [PATCH 5/8] Strategy vs. Board space fixed --- collaboration/retrospective.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/collaboration/retrospective.md b/collaboration/retrospective.md index ca66a93bb..aff75efc9 100644 --- a/collaboration/retrospective.md +++ b/collaboration/retrospective.md @@ -59,31 +59,31 @@ to foster a collaborative environment.___ ### What parts of your plan went as expected? 👍 1. __Improved understanding of code-reviewing principles__; _Throughout this pro - ject, we gained a deeper understanding of the importance of code-reviewing an +ject, we gained a deeper understanding of the importance of code-reviewing an d how to apply best practices._ 2. __Effective collaboration__; _Group members worked well together, providing c - onstructive feedback and supporting each other in the learning process which +onstructive feedback and supporting each other in the learning process which allowed us to refine our approach and improve both our coding practices and c - ommunication. This made the code review process not only more effective but a +ommunication. This made the code review process not only more effective but a lso more rewarding, as we could see visible improvements over time._ 3. __Keeping deadlines on track and the delivery of work as expected.__ ### What parts of your plan did not work out? 👎 1. __Initial struggle with code review tools__; _We faced some challenges get - ting familiar with the code review tools, but eventually got the hang of it._ +ting familiar with the code review tools, but eventually got the hang of it._ 2. __We weren't quite able to fully help each other out as a colleague of our - s decided not to continue with the program.__ +s decided not to continue with the program.__ ### Did you need to add things that weren’t in your strategy? 🤔 1. __Dedicated Learning Time for Tools__; _Some team members needed more time - to learn and practice using tools like GitHub and setting up the environment - . While we helped each other whenever needed during our meetings, it would h - ave saved time if we had set aside time specifically for learning the tools. - This could have been done either together in a session at the beginning or - by giving everyone extra time upfront to get familiar with the tools. Exte - nding the deadlines a bit would also have helped everyone feel more comforta - ble and avoided early delays._ + to learn and practice using tools like GitHub and setting up the environment +. While we helped each other whenever needed during our meetings, it would h +ave saved time if we had set aside time specifically for learning the tools. + This could have been done either together in a session at the beginning or +by giving everyone extra time upfront to get familiar with the tools. Exte +nding the deadlines a bit would also have helped everyone feel more comforta +ble and avoided early delays._ ### Or remove extra steps? 🚮 From 1c0563dcb36fe23d969807bebbb08f59df4c7e4e Mon Sep 17 00:00:00 2001 From: Gai Samuel Date: Sat, 11 Jan 2025 19:13:13 +0300 Subject: [PATCH 6/8] Corrected spacing. --- collaboration/retrospective.md | 40 +++++++++++++++++----------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/collaboration/retrospective.md b/collaboration/retrospective.md index aff75efc9..3b6c8dd6e 100644 --- a/collaboration/retrospective.md +++ b/collaboration/retrospective.md @@ -58,32 +58,32 @@ to foster a collaborative environment.___ ### What parts of your plan went as expected? 👍 -1. __Improved understanding of code-reviewing principles__; _Throughout this pro -ject, we gained a deeper understanding of the importance of code-reviewing an - d how to apply best practices._ -2. __Effective collaboration__; _Group members worked well together, providing c -onstructive feedback and supporting each other in the learning process which - allowed us to refine our approach and improve both our coding practices and c -ommunication. This made the code review process not only more effective but a - lso more rewarding, as we could see visible improvements over time._ -3. __Keeping deadlines on track and the delivery of work as expected.__ + 1. __Improved understanding of code-reviewing principles__; _Throughout this + project, we gained a deeper understanding of the importance of code-reviewing + and how to apply best practices._ + 2. __Effective collaboration__; _Group members worked well together, providing + constructive feedback and supporting each other in the learning process which + allowed us to refine our approach and improve both our coding practices and + communication. This made the code review process not only more effective but + also more rewarding, as we could see visible improvements over time._ + 3. __Keeping deadlines on track and the delivery of work as expected.__ ### What parts of your plan did not work out? 👎 - 1. __Initial struggle with code review tools__; _We faced some challenges get -ting familiar with the code review tools, but eventually got the hang of it._ - 2. __We weren't quite able to fully help each other out as a colleague of our -s decided not to continue with the program.__ + 1. __Initial struggle with code review tools__; _We faced some challenges + getting familiar with the code review tools, but eventually got the hang of it._ + 2. __We weren't quite able to fully help each other out as a colleague of + ours decided not to continue with the program.__ ### Did you need to add things that weren’t in your strategy? 🤔 1. __Dedicated Learning Time for Tools__; _Some team members needed more time - to learn and practice using tools like GitHub and setting up the environment -. While we helped each other whenever needed during our meetings, it would h -ave saved time if we had set aside time specifically for learning the tools. - This could have been done either together in a session at the beginning or -by giving everyone extra time upfront to get familiar with the tools. Exte -nding the deadlines a bit would also have helped everyone feel more comforta -ble and avoided early delays._ + to learn and practice using tools like GitHub and setting up the environment + . While we helped each other whenever needed during our meetings, it would + have saved time if we had set aside time specifically for learning the tools. + This could have been done either together in a session at the beginning or + by giving everyone extra time upfront to get familiar with the tools. + Extending the deadlines a bit would also have helped everyone feel more + comfortable and avoided early delays._ ### Or remove extra steps? 🚮 From 32641e76faef3335c8bf7cfea2ab390aea047bdc Mon Sep 17 00:00:00 2001 From: Gai Samuel Date: Sat, 11 Jan 2025 19:16:56 +0300 Subject: [PATCH 7/8] . --- collaboration/retrospective.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/collaboration/retrospective.md b/collaboration/retrospective.md index 3b6c8dd6e..42dc88702 100644 --- a/collaboration/retrospective.md +++ b/collaboration/retrospective.md @@ -78,8 +78,8 @@ to foster a collaborative environment.___ ### Did you need to add things that weren’t in your strategy? 🤔 1. __Dedicated Learning Time for Tools__; _Some team members needed more time - to learn and practice using tools like GitHub and setting up the environment - . While we helped each other whenever needed during our meetings, it would + to learn and practice using tools like GitHub and setting up the environment. + While we helped each other whenever needed during our meetings, it would have saved time if we had set aside time specifically for learning the tools. This could have been done either together in a session at the beginning or by giving everyone extra time upfront to get familiar with the tools. From 879ce880f945ed796e52cafff15a74b59f684699 Mon Sep 17 00:00:00 2001 From: Gai Samuel Date: Sat, 11 Jan 2025 21:31:30 +0300 Subject: [PATCH 8/8] Added Zeinab and Linah's suggetions. --- collaboration/retrospective.md | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/collaboration/retrospective.md b/collaboration/retrospective.md index 42dc88702..2e23a072f 100644 --- a/collaboration/retrospective.md +++ b/collaboration/retrospective.md @@ -16,6 +16,10 @@ to foster a collaborative environment.___ ## Stop doing 🙅‍♂️ 1. Stop merging changes without proper reviews. + 2. Avoid sharing external links or performing actions that do not comply with + the application’s policy to ensure security and consistency. + 3. Stop opening Pull Requests without verifying the target branch to prevent + errors and confusion in the version control process. ## Continue doing 👍 @@ -26,11 +30,15 @@ to foster a collaborative environment.___ 5. Automated testing for critical features 6. Setting clear deadlines for deliverables 7. Sharing resources and insights to improve team knowledge and skills collectively. + 8. Divide tasks before starting to ensure clear responsibilities. + 9. Ask for help when facing challenges to avoid unnecessary delays. + Consider all perspectives when solutions differ. Refer to reliable resources, + and discuss the options with the team to decide on the best approach. ## Start doing 🚀 1. __Conducting regular check-ins to align on progress and adjust priorities - as needed.__ + as needed.__ 2. __Tracking and addressing recurring issues__; _We noticed that some issues, like not using descriptive enough names for variables (e.g., naming a variable s instead of binary_str), kept coming up during our reviews. To @@ -38,6 +46,16 @@ to foster a collaborative environment.___ individually each time, we plan to keep a shared list of these common issues. This way, everyone can see and remember them, helping us improve and use better practices in future projects._ + 3. __Sharing knowledge among team members before starting the project__: _By + sharing our individual skills and knowledge at the start, we can help each + other become more effective and efficient in the work we do._ + 4. __Creating a list of each member’s skills and capabilities__: _Knowing who + is + best suited for each task will enable us to make better decisions on task + delegation and leverage everyone's strengths._ + 5. __Documenting work steps, policies, and best practices__: _Clear documentation + will ensure that all team members are on the same page, reducing confusion + and the chances of mistakes in the future._ ## Lessons Learned 🎓 @@ -51,6 +69,15 @@ to foster a collaborative environment.___ this process offered an opportunity to grow and refine our practices._ 6. __Effective prioritization leads to efficiency__: _Focus on the most impactful changes during reviews to optimize time and effort._ + 7. __Focusing on weaknesses and learning from others__: _Recognizing areas of + improvement, learning from mistakes, and taking guidance from others are + crucial for personal and team growth._ + 8. __Frequent code reviews enhance expertise__: _Regular code reviews not only + improve the quality of our code but also reduce errors in our own work._ + 9. __Clear initial planning and sharing it with the team__: _Creating a clear + plan + at the beginning and sharing it with everyone helps to streamline the project + and avoid confusion later on._ --- @@ -87,3 +114,5 @@ to foster a collaborative environment.___ comfortable and avoided early delays._ ### Or remove extra steps? 🚮 + +We didn't have any members remove steps in their strategy.