number of approvals to merge branch

[Mohamed-Elnageeb]

hello guys,
Currently, our repository requires only one approval for pull requests (PRs) before merging. This is incosistent with what we agrred upon ( having two reviewers per task) so I want to increase the required approvals for PRs to two reviewers in the branch protection rules.

so what do you guys think

[GaiSamuel]

Actually, we can leave it as it is because we will be reviewing one task per person, and then others can later add their reviews once they are done with their assigned tasks. But I'm not sure every task will get more than one review.

[Mohamed-Elnageeb]

but we assigned to reviewers per task and agreed upon it , this makes it abit inconsistent with the settings

[GaiSamuel]

Just noticed now yeah you right and the setting being 1 needed approval might become a problem if someone merges changes when the 2nd person hasn't reviewed

[Zeinab15]

So based on this anyone should review 4 challenges right ? @Mohamed-Elnageeb

[GaiSamuel]

We are reviewing two challenges of each person we are assigned to. That makes it 4 yeah

[Mohamed-Elnageeb]

On average yes