Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will this automatically work with new expansions or does it need to be updated #20

Open
elmstreetvictim opened this issue Mar 23, 2019 · 4 comments

Comments

@elmstreetvictim
Copy link

I see the the localization document that was last updated 4 months ago for Rastakhan. Is it possible to update this file now, since we know the name of the expansion? Or is the dictionary and the integer key an item that is not known at this time? IE the Witchwood is like 31, Boomsday is 38 and Rastakhan is 40.

I want to open a lot of packs on launch day and want to make sure I can keep track of the pity timers.

Thank you all.

@MGK82
Copy link
Owner

MGK82 commented Apr 8, 2019

Hello.
Even if the expansion's id is not provided for localization, it will still be recorded. The only downside is, that the expansion will be represented by its id, instaed of a propper name, until the updated localization comes into play.

I always have to wait for the HDT guys to update there code, which will expose the id to me. So far, the added id is 49 with the title "DALARAN", which confuses me. I hope it is the right id.

If not, we will see on release and I can update it again. I just wouldn't like to have two updates.

Anyway, again: No data will be lost and everything will be recorded as usual, if there is no localization for a new expansion in time. It will only look ugly on the surface, because there is nothing else to show than the blank id.

@elmstreetvictim
Copy link
Author

elmstreetvictim commented Apr 8, 2019 via email

@MGK82
Copy link
Owner

MGK82 commented Apr 8, 2019

Sorry, I guess I havn't made it clear. I just released an update. You can get it already through the autoupdate or manually.

Just in case the id isn't correct, there will be another update tomorrow.

@elmstreetvictim
Copy link
Author

elmstreetvictim commented Apr 8, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants