Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky MOUNT D64 and Short Name Issues #199

Closed
johnwayner opened this issue Feb 15, 2025 · 1 comment
Closed

Sticky MOUNT D64 and Short Name Issues #199

johnwayner opened this issue Feb 15, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@johnwayner
Copy link

Test Environment (required)

Describe the bug
The feature that remounts the previously mounted disk image on a reset fails in two cases:

  • when the disk image name is short: A.D81, T.D64, etc.
  • when the image is a D64

To Reproduce
Steps to reproduce the behavior:

  1. MOUNT A.D81 (or any D64)
  2. reset machine using side button
  3. DIR (returns drive not ready)

Expected behavior
The previously mounted image is properly remounted so that the DIR returns a directory listing.

Additional context
I have fixes for both of these. The short name is an off-by-one error when checking for a too-short name. The second is due to the extension of the image name always being overwritten with .D81 even though the entire name is saved.

Adjacent Issue?
The ROM always remounts the most recently mounted image -- even if it was not mounted at the time of reset. This feels wrong to me, but perhaps it should be a separate issue.

@johnwayner johnwayner added the new New report, not classified yet label Feb 15, 2025
@dansanderson
Copy link
Collaborator

We want Hyppo to own sticky mounting in the future. I don't know how close we are to implementing it but we've mostly agreed it's the right thing. #192

@dansanderson dansanderson added bug Something isn't working and removed new New report, not classified yet labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants