Photos in-between two selected photos are not selecting when using shift-select to select multiple photos

[sancsin]

Lychee version

master (d0502bf)

Which PHP version are you using?

PHP 8.3

Detailed description of the problem

Current behaviour

When shift selecting first photo in an album and then selecting another photo later in the album, photos in-between these two photos are not selected

Expected behaviour

When shift selecting first photon in an album and then selecting another photo later in the album, photos in-between these two photos are selected

Steps to reproduce the issue

1. Open any album with multiple photos
2. Select the first photo in the album
3. Select another photo within the album
4. Observe that the photos between the two selected photos are not selected

Diagnostics [REQUIRED]

Self-diagnosis:

Info: Latest version of PHP is 8.4
Info: Found 148 medium that could be generated.
You can use php artisan lychee:generate_thumbs medium 148 to generate them.
Info: Found 2 medium2x that could be generated.
You can use php artisan lychee:generate_thumbs medium2x 2 to generate them.

Info:

Lychee SE Version (git): master (d0502bf) -- Up to date (1 days ago).
DB Version: 6.2.0

Docker: false
composer install: --no-dev
APP_ENV: production
APP_DEBUG: false
APP_URL: set
APP_DIR: default
LOG_VIEWER_ENABLED: true
VUEJS_ENABLED: true
PHOTO_PIPES: true

System: Linux
PHP Version: 8.3.6
PHP User agent: Lychee/6 (https://lycheeorg.dev/)
Timezone: Europe/Stockholm
Max uploaded file size: 500M
Max post size: 500M
Chunk size: 12.80 MB
Max execution time: 200
SQLite Version: 3.45.1

exec() Available: yes
Imagick Available: 1
Imagick Enabled: 1
Imagick Version: 1692
GD Version: 2.3.3
Number of foreign key: 11 found.

Config:

version: 060200
check_for_updates: 0
sorting_photos_col: taken_at
sorting_photos_order: ASC
sorting_albums_col: min_taken_at
sorting_albums_order: ASC
imagick: 1
skip_duplicates: 1
small_max_width: 0
small_max_height: 360
medium_max_width: 1920
medium_max_height: 1080
lang: en
image_overlay_type: desc
default_license: none
compression_quality: 90
grants_full_photo_access: 1
delete_imported: 0
mod_frame_enabled: 1
mod_frame_refresh: 30
thumb_2x: 1
small_2x: 1
medium_2x: 1
landing_page_enable: 1
force_migration_in_production: 0
search_public: 0
hide_version_number: 0
SL_enable: 0
SL_for_admin: 0
recent_age: 1
grants_download: 0
photos_wraparound: 1
map_display: 1
zip64: 1
map_display_public: 0
map_provider: Wikimedia
force_32bit_ids: 0
map_include_subalbums: 1
update_check_every_days: 3
has_exiftool: 1
share_button_visible: 0
import_via_symlink: 0
has_ffmpeg: 1
location_decoding: 1
location_decoding_timeout: 30
location_show: 1
location_show_public: 0
rss_enable: 0
rss_recent_days: 7
rss_max_items: 100
prefer_available_xmp_metadata: 0
editor_enabled: 1
lossless_optimization: 0
swipe_tolerance_x: 150
swipe_tolerance_y: 250
local_takestamp_video_formats: .avi|.mov
log_max_num_line: 1000
unlock_password_photos_with_url_param: 0
nsfw_visible: 1
nsfw_blur: 0
nsfw_warning: 0
nsfw_warning_admin: 0
nsfw_banner_override:
map_display_direction: 1
album_subtitle_type: oldstyle
upload_processing_limit: 0
new_photos_notification: 1
legacy_id_redirection: 1
zip_deflate_level: 6
default_album_protection: 1
album_decoration: layers
album_decoration_orientation: row
allow_username_change: 1
auto_fix_orientation: 0
use_job_queues: 1
random_album_id: starred
use_last_modified_date_when_no_exif_date: 0
layout: justified
date_format_photo_thumb: M j, Y, g:i:s A e
date_format_photo_overlay: M j, Y, g:i:s A e
date_format_sidebar_uploaded: M j, Y, g:i:s A e
date_format_sidebar_taken_at: M j, Y, g:i:s A e
date_format_hero_min_max: F Y
date_format_hero_created_at: M j, Y, g:i:s A T
date_format_album_thumb: M Y
upload_chunk_size: 0
nsfw_banner_blur_backdrop: 0
search_pagination_limit: 1000
search_minimum_length_required: 4
photo_layout_justified_row_height: 320
photo_layout_masonry_column_width: 300
photo_layout_grid_column_width: 250
photo_layout_square_column_width: 200
photo_layout_gap: 12
display_thumb_album_overlay: always
display_thumb_photo_overlay: hover
default_album_thumb_aspect_ratio: 1/1
use_album_compact_header: 0
login_button_position: left
back_button_enabled: 1
back_button_text: Return to Home
current_job_processing_visible: 1
SA_random_thumbs: 0
job_processing_queue_visible: 1
login_required: 0
enable_unsorted: 1
enable_starred: 1
enable_recent: 1
enable_on_this_day: 1
login_required_root_only: 1
dark_mode_enabled: 1
show_keybinding_help_popup: 0
show_keybinding_help_button: 1
disable_se_call_for_actions: 1
enable_se_preview: 1
slideshow_timeout: 5
keep_original_untouched: 1
low_quality_image_placeholder: 0
timeline_photos_enabled: 1
timeline_photos_public: 0
timeline_photos_granularity: day
timeline_photos_order: taken_at
timeline_photos_layout: square
timeline_photos_pagination_limit: 200
timeline_albums_enabled: 1
timeline_albums_public: 0
timeline_albums_granularity: year
timeline_left_border_enabled: 1
timeline_photo_date_format_year: Y
timeline_photo_date_format_month: M Y
timeline_photo_date_format_day: j M Y
timeline_photo_date_format_hour: g:i
timeline_album_date_format_year: Y
timeline_album_date_format_month: M Y
timeline_album_date_format_day: j M
hide_nsfw_in_smart_albums: 1
hide_nsfw_in_frame: 1
hide_nsfw_in_map: 1
hide_nsfw_in_search: 1
search_photos_layout: square
hide_nsfw_in_rss: 1
hide_nsfw_in_timeline: 1
number_albums_per_row_mobile: 3
cache_enabled: 0
cache_ttl: 300

Browser & System [REQUIRED]

System

Operating System: Manjaro Linux
KDE Plasma Version: 6.2.4
KDE Frameworks Version: 6.8.0
Qt Version: 6.8.1
Kernel Version: 6.6.65-1-MANJARO (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-9700K CPU @ 3.60GHz
Memory: 31.3 GiB of RAM
Graphics Processor: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2

Browser

Google Chrome Version 131.0.6778.204 (Official Build) (64-bit)

Please confirm (incomplete submissions will not be addressed)

• I have provided easy and step-by-step instructions to reproduce the bug.
• I understand my bug report will be removed if I haven't met the criteria above.

[ildyria]

I have hard time reproducing that one.

[sancsin]

It happens the first time you open an album. I think you will see what I mean when you see my PR. We are not setting lastPhotoClicked and lastAlbumClicked when the selectedPhotos and selectedAlbums lists are first initialized

Here is a video showing the bug

2025-02-06.23-11-06.mp4

Here is the video with the bugfix

2025-02-06.23-11-37.mp4

[sancsin]

Fixed by PR #2994