Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Issue for Reactant Compilation of Lux Models #733

Open
5 of 9 tasks
avik-pal opened this issue Jun 26, 2024 · 2 comments
Open
5 of 9 tasks

Meta Issue for Reactant Compilation of Lux Models #733

avik-pal opened this issue Jun 26, 2024 · 2 comments

Comments

@avik-pal
Copy link
Member

avik-pal commented Jun 26, 2024

WIP PRs

Upcoming Work

  • Compiling Lux models and offload part of the computation to XLA and adding ChainRules and EnzymeRules support to call the generated VJP rules

List of missing operations

It is mostly an incomplete list, but certain operations are known not to work

Shortcomings in Lux design that can be improved

  • states are not updated in-place making it not ideal for both Enzyme and Reactant. This is honestly hard to fix at this point.

Core Layers Missing Adjoints

  • Embedding -- stablehlo.dynamic_gather
  • Pooling -- stablehlo.reduce_window
  • Conv -- stablehlo.convolution / stablehlo.dynamic_conv
@avik-pal avik-pal added the xla label Jun 26, 2024
@avik-pal avik-pal mentioned this issue Jun 26, 2024
32 tasks
@wsmoses
Copy link
Contributor

wsmoses commented Jun 26, 2024

@avik-pal since Reactant has a lot more than just XLA, including custom linear algebra/fusion optimiations, MLIR AD, etc, can this be renamed Reactant compilation rather than xla?

@avik-pal avik-pal changed the title Meta Issue for XLA Compilation of Lux Models Meta Issue for Reactant Compilation of Lux Models Jun 26, 2024
@avik-pal avik-pal pinned this issue Jul 3, 2024
@avik-pal

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants