-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port mainstream patches #52
Comments
Also, I suggest considering the rest of the patches as well. It seems like Box2D has received plenty of updates in the last three years. |
I switched mainstream to the original (Box2D from Erin Catto). This particular code snippet, I must have overlooked when comparing the code with the original. I'll supply a fix for that. I've skimmed over the changes from flyover and the only ones that seemed like they have not been refactoring/cleanup commits or upstream changes (from Original), which I've done myself already, are these: flyover@1d2cc3a#diff-eb7280cee2bd76f87794feeb11aba32b708b60cebb310977a8f1f07f69189477 flyover@c9bf588#diff-b7b2e775ba814d459e85a01d20a5c04cfa9f38ff82380d9bd887dbe798f6d22f And they seem more like features and changes that to not relate to the Original. Not sure if I want to port those changes. Feel free to offer reasons. |
I don't insist on porting these changes; it was just a general suggestion. Since you had this bug in your codebase, I thought you were using a three-year-old version. |
The way I compare changes with the c++ version requires high attention. I guess I must have thought, that this was an improvement for JS that flyover added to avoid going over all elements. I didn't realize, that a proxy could exist multiple times in the array. I've added a review to your PR. When that is cleared, I'll merge. Thanks! |
This version of Box2D is affected by flyover#79.
b2BroadPhase.UnBufferMove
does not remove some proxy moves resulting in assertion failure inb2BroadPhase.UpdatePairs
. The suggested fix is to port flyover@48e167c.The text was updated successfully, but these errors were encountered: