Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable automatic speaker selection #14

Open
Logodaedalus opened this issue Dec 17, 2018 · 1 comment
Open

Re-enable automatic speaker selection #14

Logodaedalus opened this issue Dec 17, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@Logodaedalus
Copy link
Contributor

Logodaedalus commented Dec 17, 2018

Essentially deactivated for now (if not present in config, defaults to monologue, which doesn't really do anything currently) but there's a deactivated StoryAssembler to automatically pick fragments based on who the speaker is as well. This feature was implemented back in...2017? 2016? Then it was abandoned and drifted into "deactivation-by-code-never-executed" over time. It used to have three different modes (narration, monologue, dialogue) and would prioritize fragments that allowed the normal exchange to continue.

Currently you'd need to add

"mode" : {			//what mode dialogue exchange takes place in for the scene
   "type": "dialogue",		//can be dialogue or monologue
   "initiator": "friend1",
   "responder": "protagonist"
},

to your config file, and make sure each fragment has a speaker.

This could probably also come back integrated in with the avatar stuff, as that seems to be where a lot of character logic-y stuff is now.

@Logodaedalus Logodaedalus added the enhancement New feature or request label Dec 17, 2018
@Logodaedalus
Copy link
Contributor Author

We'd also basically need to refactor Character.js:getBestSpeaker() because that's got a bunch of kludges in that currently are called on every fragment, and essentially (AFAIK) always returns the first character in the scene as the "speaker", which is then never used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant