Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Export] fetch_nwb assumes fetching table inherits the mixin #1185

Closed
CBroz1 opened this issue Nov 14, 2024 · 0 comments · Fixed by #1192
Closed

[Export] fetch_nwb assumes fetching table inherits the mixin #1185

CBroz1 opened this issue Nov 14, 2024 · 0 comments · Fixed by #1192
Assignees
Labels
bug Something isn't working infrastructure Unix, MySQL, etc. settings/issues impacting users

Comments

@CBroz1
Copy link
Member

CBroz1 commented Nov 14, 2024

The use of log_export in fetch_nwb assumes that the query expression has our custom join

nwb_files = (
query_expression.join(
tbl.proj(nwb2load_filepath=attr_name), log_export=False
)
).fetch(file_name_str)

This should be edited to first run a check that query_expression is an instance of SpyglassMixin

@CBroz1 CBroz1 self-assigned this Nov 14, 2024
@CBroz1 CBroz1 added bug Something isn't working infrastructure Unix, MySQL, etc. settings/issues impacting users labels Nov 14, 2024
CBroz1 added a commit to CBroz1/spyglass that referenced this issue Nov 20, 2024
@CBroz1 CBroz1 linked a pull request Nov 21, 2024 that will close this issue
7 tasks
@CBroz1 CBroz1 mentioned this issue Nov 27, 2024
7 tasks
edeno pushed a commit that referenced this issue Dec 5, 2024
* #1175

* #1185

* #1183

* Fix circular import

* #1163

* #1105

* Fix failing tests, close download subprocesses

* WIP: fix decode changes spikesort tests

* Fix fickle test

* Revert typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Unix, MySQL, etc. settings/issues impacting users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant