Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve View Tests, Implement missing test #34

Open
3 tasks
Lordnibbler opened this issue Jul 24, 2014 · 0 comments
Open
3 tasks

Improve View Tests, Implement missing test #34

Lordnibbler opened this issue Jul 24, 2014 · 0 comments
Labels
enhancement

Comments

@Lordnibbler
Copy link
Owner

Missing tests

  • /views/app.js#saveColor()
    • Needs either a Sinon fake server or a .yieldsTo('success')

Improve Tests

Use jQuery selectors/finders based off View.$el instead of matching strings.

  • /views/savedColor.js
  • /views/savedColors.js
@Lordnibbler Lordnibbler changed the title Test: views/app.js#saveColor Improve View Tests, Implement missing test Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lordnibbler