Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Not able to add a new rule in Firefox when icon is inside of the Overflow Menu #23

Open
mig8447 opened this issue Jun 15, 2021 · 7 comments

Comments

@mig8447
Copy link

mig8447 commented Jun 15, 2021

When trying to add a new rule in Firefox (Mac or Windows) the buttons and checkboxes below the editor are cut off and the "Add" blue button is not shown at all. I tried to increase the height of the dialog in the add-on options but it kept cutting the controls off

@Filius-Patris
Copy link

Can't reproduce with most recent FF (89.0.1) on MacOS Catalina (10.15.7). Care to attach some screenshots?

@mig8447
Copy link
Author

mig8447 commented Jun 25, 2021

Hi,

I'm using Firefox 89.0.1 in macOS Mojave 10.14.6. Not even modifying the configuration to make the panel bigger helps.

CleanShot 2021-06-25 at 08 07 27

CleanShot 2021-06-25 at 08 09 33

And the same issue is present in FF 89.0.1 in Windows 10

firefox_C6GyMVlpk7

@Filius-Patris
Copy link

Thanks!

This pop-up has a FF-native border on the top. From which menu are you accessing the CI settings?

I usually have the Code Injector in the hotbar and click it's icon there.

@Filius-Patris
Copy link

Filius-Patris commented Jun 28, 2021

Ah, ok, I launched it from the oberflow menu too, but I couldn't reproduce the issue.

Maybe it has something to do with the values for the pop-up size in the addon preferences? Mind sharing these values?

@mig8447
Copy link
Author

mig8447 commented Jun 29, 2021

Sure, here they are, thanks for looking into this. BTW Upgrade to FF 89.0.2 did not help either in either Windows or macOS. Note that I also tried to modify these settings and making it taller didn't help

CleanShot 2021-06-29 at 05 07 42

@mig8447
Copy link
Author

mig8447 commented Jun 29, 2021

From which menu are you accessing the CI settings?

Oh, I got the CI icon into FF's overflow menu. Just got it out of there and the issue was fixed. So this is a great workaround. I'd say this is not a show stopper anymore since there's a workaround but it is still a bug when the icon is put into the overflow menu. Thank you very much for this again.

@mig8447 mig8447 changed the title SHOW STOPPER: Not able to add a new rule in Firefox BUG: Not able to add a new rule in Firefox when icon is inside of the Overflow Menu Jun 29, 2021
@y1n0
Copy link

y1n0 commented Sep 16, 2021

This only happens if the add-on is pinned to overflow menu. as a workaround to anyone dealing with this, you can temporarily unpin the icon from the overflow menu and let it show on the bar next to the address bar, then you can use normally.

I could have saved so much time if I knew this, instead of trying to tweak its css. hope this helps someone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants