Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misspelled variable definition leads to errors during document export #1

Closed
Athemis opened this issue Mar 16, 2015 · 1 comment · May be fixed by #2
Closed

Misspelled variable definition leads to errors during document export #1

Athemis opened this issue Mar 16, 2015 · 1 comment · May be fixed by #2
Assignees
@LokeshN

Comments

@Athemis
Copy link

Athemis commented Mar 16, 2015

When trying to export a document (e.g. as PDF or ODT) with installed ep_foot_note, etherpad-lite crashes with the following error:

[2015-03-16 16:14:29.416] [ERROR] console - ReferenceError: ChangeSet is not defined
    at checkFootNoteInLine (/usr/share/webapps/etherpad-lite/node_modules/ep_foot_note/footNote.js:21:14)
    at Object.getLineHTMLForExport [as hook_fn] (/usr/share/webapps/etherpad-lite/node_modules/ep_foot_note/footNote.js:11:11)
    at normalizedhook (/usr/share/webapps/etherpad-lite/src/static/js/pluginfw/hooks.js:15:27)
    at hookCallWrapper (/usr/share/webapps/etherpad-lite/src/static/js/pluginfw/hooks.js:21:14)
    at /usr/share/webapps/etherpad-lite/src/static/js/pluginfw/hooks.js:76:14
    at Array.map (native)
    at Function._.map._.collect (/usr/share/webapps/etherpad-lite/src/node_modules/underscore/underscore.js:98:56)
    at Object.exports.callAll (/usr/share/webapps/etherpad-lite/src/static/js/pluginfw/hooks.js:75:24)
    at Object.exports.callAllStr (/usr/share/webapps/etherpad-lite/src/static/js/pluginfw/hooks.js:122:27)
    at getHTMLFromAtext (/usr/share/webapps/etherpad-lite/src/node/utils/ExportHtml.js:422:39)

The variable definition of "ChangeSet" is misspelled as "Changeset" in footNote.js
@Athemis Athemis mentioned this issue Mar 16, 2015
Open
@LokeshN
Copy link
Owner

LokeshN commented Mar 26, 2015

Fixed.

@LokeshN LokeshN self-assigned this Mar 26, 2015
@LokeshN LokeshN closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LokeshN LokeshN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in variable name Athemis/ep_foot_note
2 participants
@Athemis @LokeshN