From 7ab056f0af69b2224574fe4c2ac62751b91d4c77 Mon Sep 17 00:00:00 2001
From: OEOTYAN <OEOTYAN@outlook.com>
Date: Mon, 29 Jan 2024 19:28:57 +0800
Subject: [PATCH] fix: export PluginManager virtual function

---
 src/ll/api/plugin/PluginManager.h | 6 +++---
 src/ll/api/service/Service.cpp    | 1 -
 src/ll/api/service/Service.h      | 4 +---
 3 files changed, 4 insertions(+), 7 deletions(-)
 delete mode 100644 src/ll/api/service/Service.cpp

diff --git a/src/ll/api/plugin/PluginManager.h b/src/ll/api/plugin/PluginManager.h
index a6d6401a2a..ddf3cb8227 100644
--- a/src/ll/api/plugin/PluginManager.h
+++ b/src/ll/api/plugin/PluginManager.h
@@ -37,14 +37,14 @@ class PluginManager {
 
     LLAPI bool erasePlugin(std::string_view name);
 
-    virtual ~PluginManager();
+    LLAPI virtual ~PluginManager();
 
     virtual bool load(Manifest manifest) = 0;
 
     virtual bool unload(std::string_view name) = 0;
 
-    virtual bool enable(std::string_view name);
+    LLAPI virtual bool enable(std::string_view name);
 
-    virtual bool disable(std::string_view name);
+    LLAPI virtual bool disable(std::string_view name);
 };
 } // namespace ll::plugin
diff --git a/src/ll/api/service/Service.cpp b/src/ll/api/service/Service.cpp
deleted file mode 100644
index 17ce0b44db..0000000000
--- a/src/ll/api/service/Service.cpp
+++ /dev/null
@@ -1 +0,0 @@
-#include "ll/api/service/Service.h"
diff --git a/src/ll/api/service/Service.h b/src/ll/api/service/Service.h
index 323dbf937a..d353b7979d 100644
--- a/src/ll/api/service/Service.h
+++ b/src/ll/api/service/Service.h
@@ -6,7 +6,7 @@ namespace ll::service {
 
 class Service {
 public:
-    LLAPI virtual ~Service() = 0;
+    virtual ~Service() = default;
 
     [[nodiscard]] virtual ServiceId getServiceId() const noexcept = 0;
 
@@ -22,8 +22,6 @@ class Service {
     Service& operator=(Service&&)      = delete;
 };
 
-inline Service::~Service() = default;
-
 template <class T>
 concept IsService = std::is_base_of_v<Service, T> && requires {
     T::ServiceId;