Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No detection for duplicate customers #4

Open
Linxcathyyy opened this issue Nov 12, 2021 · 1 comment
Open

No detection for duplicate customers #4

Linxcathyyy opened this issue Nov 12, 2021 · 1 comment

Comments

@Linxcathyyy
Copy link
Owner

Linxcathyyy commented Nov 12, 2021

Screenshot 2021-11-12 at 4.37.20 PM.png

I am able to add the exact same client into the database by just changing the uppercase to lowercase, and other details remain the same. No warning or error message is shown.

Same issue for supplier and employee.

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 16, 2021

Team's Response

We do have a certain form of duplication detection, it's just that we missed out on the case you provided. However, this is unlikely to hinder user experience, so this should be low severity. Thank you for flagging it out.

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: Hi there, I don't think this happens only in rare situations as the add command is commonly used. In addition, no warning is shown when I try to add the duplicate client/employee/supplier. I believe this is a flaw that causes occasional inconvenience to some users but they can continue to use the product. Hence, the severity should be medium.

Screenshot 2021-11-17 at 1.15.13 PM.png
Screenshot 2021-11-17 at 1.17.10 PM.png


Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants