Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resource offer lookup by address performance #485

Closed
bgins opened this issue Jan 14, 2025 · 2 comments
Closed

Improve resource offer lookup by address performance #485

bgins opened this issue Jan 14, 2025 · 2 comments
Assignees
@zhuhaicity
Labels
community solver

Comments

@bgins
Copy link
Contributor

bgins commented Jan 14, 2025

General Description

The solver memory store has a GetResourceOfferByAddress has a method that can be optimized with faster string comparisons over resource providers.

Which system(s) or functionality does this affect

This change affects the solver only.

Describe the changes, and how this affects/ interacts with each system.

The change is a code optimization that has already been implemented by @zhuhaicity in this PR: #482
@bgins bgins assigned bgins and unassigned bgins Jan 14, 2025
@bgins bgins mentioned this issue Jan 14, 2025
Merged
@zhuhaicity
Copy link
Contributor

I have implemented this

@bgins
Copy link
Contributor Author

bgins commented Jan 16, 2025

Closed by #482

@bgins bgins closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhuhaicity zhuhaicity

Labels
community solver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgins @zhuhaicity