Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Clip_Score to calculate similarities between same modalities #2875

Merged
merged 81 commits into from
Jan 25, 2025

Conversation

rittik9
Copy link
Contributor

@rittik9 rittik9 commented Dec 19, 2024

What does this PR do?

Fixes #2865

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2875.org.readthedocs.build/en/2875/

@mergify mergify bot removed the has conflicts label Dec 19, 2024
@rittik9 rittik9 changed the title Enhance Clip_Score to calculate similarities between same modalities Enhance Clip_Score to calculate similarities between same modalities [WIP] Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 12.72727% with 48 lines in your changes missing coverage. Please review.

Project coverage is 32%. Comparing base (520a868) to head (1abb671).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (520a868) and HEAD (1abb671). Click for more details.

HEAD has 270 uploads less than BASE
Flag BASE (520a868) HEAD (1abb671)
torch2.6.0+cpu 10 2
Windows 15 3
python3.11 20 4
cpu 84 17
torch2.0.1+cpu 15 3
python3.10 44 9
torch2.5.0+cpu 15 3
python3.12 15 3
macOS 20 4
torch2.5.0 5 1
torch2.6.0 5 1
torch2.0.1 10 2
Linux 49 10
torch2.4.1+cpu 10 2
torch2.3.1+cpu 4 1
torch2.1.2+cpu 5 1
torch2.2.2+cpu 5 1
python3.9 5 1
gpu 1 0
unittest 1 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2875     +/-   ##
========================================
- Coverage      69%     32%    -37%     
========================================
  Files         346     332     -14     
  Lines       19146   18996    -150     
========================================
- Hits        13233    6056   -7177     
- Misses       5913   12940   +7027     

@rittik9
Copy link
Contributor Author

rittik9 commented Jan 7, 2025

@Borda I am planning to add some tests for new feature (calculate clip score in same modality). I am trying to understand how the reference metric should be.

@rittik9 rittik9 changed the title Enhance Clip_Score to calculate similarities between same modalities [WIP] Enhance Clip_Score to calculate similarities between same modalities Jan 9, 2025
@mergify mergify bot added the ready label Jan 9, 2025
@Borda Borda merged commit 5fc2e0b into Lightning-AI:master Jan 25, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend CLIP Score to image-to-image and text-to-text similarity
2 participants