Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with shared state of MetricCollection compute group when using DiceScore(average="weighted") #2848

Conversation

nkaenzig
Copy link
Contributor

@nkaenzig nkaenzig commented Nov 28, 2024

What does this PR do?

Fixes #2847

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Tested using the code snippet provided in the issue description.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2848.org.readthedocs.build/en/2848/

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35%. Comparing base (a968ebe) to head (3132783).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a968ebe) and HEAD (3132783). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (a968ebe) HEAD (3132783)
gpu 1 0
unittest 1 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2848     +/-   ##
========================================
- Coverage      69%     35%    -34%     
========================================
  Files         346     332     -14     
  Lines       19129   18952    -177     
========================================
- Hits        13227    6590   -6637     
- Misses       5902   12362   +6460     

@nkaenzig nkaenzig changed the title Fix issue with shared state of MetricCollection compute group when using DiceScore(average="weighted") Fix issue with shared state of MetricCollection compute group when using DiceScore(average="weighted") Nov 28, 2024
@mergify mergify bot added the ready label Nov 29, 2024
@Borda Borda enabled auto-merge (squash) December 11, 2024 07:00
@Borda Borda merged commit cd24d2b into Lightning-AI:master Dec 11, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiceScore(average="weighted") doesn't work when in same compute group within MetricCollection
3 participants