Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: group skip wrappers & make them optional #2372

Merged
merged 3 commits into from
Feb 13, 2024
Merged

tests: group skip wrappers & make them optional #2372

merged 3 commits into from
Feb 13, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 12, 2024

What does this PR do?

We may have a lot of silently skipped tests, so let's keep then for skip on PR but always run on master or release...

Workload:

  • find and group test wrappers to a single module
  • patch Workflows to allow skip on PR
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2372.org.readthedocs.build/en/2372/

@Borda Borda changed the title tests: group wrappers & make them optional tests: group skip wrappers & make them optional Feb 12, 2024
@Borda Borda marked this pull request as ready for review February 12, 2024 20:59
@Borda Borda changed the title tests: group skip wrappers & make them optional tests: group skip wrappers & make them optional [wip] Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Merging #2372 (d95bb7c) into master (ff701bb) will decrease coverage by 0%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2372   +/-   ##
======================================
- Coverage      69%     69%   -0%     
======================================
  Files         305     305           
  Lines       17180   17180           
======================================
- Hits        11840   11839    -1     
- Misses       5340    5341    +1     

@Borda Borda changed the title tests: group skip wrappers & make them optional [wip] tests: group skip wrappers & make them optional Feb 13, 2024
@Borda
Copy link
Member Author

Borda commented Feb 13, 2024

let's add The pr skip to CI when we see some issues 🐿️

@mergify mergify bot added the ready label Feb 13, 2024
@Borda Borda requested a review from ethanwharris as a code owner February 13, 2024 14:27
@Borda Borda merged commit ee1a529 into master Feb 13, 2024
53 of 57 checks passed
@Borda Borda deleted the test/wrappers branch February 13, 2024 15:23
Borda added a commit that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants