Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy import audio #2181

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Lazy import audio #2181

merged 2 commits into from
Oct 17, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 17, 2023

What does this PR do?

Fixes part of #2171

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2181.org.readthedocs.build/en/2181/

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2181 (c44032f) into master (09bd064) will decrease coverage by 51%.
Report is 5 commits behind head on master.
The diff coverage is 91%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2181     +/-   ##
========================================
- Coverage      87%     36%    -51%     
========================================
  Files         293     293             
  Lines       16410   16402      -8     
========================================
- Hits        14256    5847   -8409     
- Misses       2154   10555   +8401     

@mergify mergify bot added the ready label Oct 17, 2023
@Borda Borda enabled auto-merge (squash) October 17, 2023 15:36
@Borda Borda disabled auto-merge October 17, 2023 16:07
@Borda Borda merged commit fe7830c into master Oct 17, 2023
@Borda Borda deleted the lazy_import/audio branch October 17, 2023 16:08
Borda pushed a commit that referenced this pull request Nov 30, 2023
(cherry picked from commit fe7830c)
Borda pushed a commit that referenced this pull request Dec 1, 2023
(cherry picked from commit fe7830c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants