Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fall back with some old configs #2164

Merged
merged 17 commits into from
Oct 17, 2023
Merged

ci: fall back with some old configs #2164

merged 17 commits into from
Oct 17, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 11, 2023

What does this PR do?

  • Disable testing for windows and pytorch 2.1. It works locally for me so cannot reproduce, so it is probably some dependency issue that leads to memory access violations. Skip for now to get CI stable.
  • Change docker image use for old testing since the cuda kernel currently used is not supported
  • Increase some timeouts
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2164.org.readthedocs.build/en/2164/

@SkafteNicki SkafteNicki added the test / CI testing or CI label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2164 (6167e5d) into master (09bd064) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2164   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         293     293           
  Lines       16410   16410           
======================================
  Hits        14256   14256           
  Misses       2154    2154           

@mergify mergify bot added the ready label Oct 11, 2023
@SkafteNicki SkafteNicki requested a review from lantiga as a code owner October 11, 2023 09:19
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 11, 2023
@SkafteNicki SkafteNicki changed the title Try fixing flaky tests Make CI stable again Oct 17, 2023
@Borda Borda changed the title Make CI stable again ci: fall back with some old configs Oct 17, 2023
@Borda Borda merged commit 1903e11 into master Oct 17, 2023
78 checks passed
@Borda Borda deleted the flaky branch October 17, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants